Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

Issue 2587293002: DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js b/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
index e72872cf2d12823338f312a5ea9b54f49aa8a29d..0ca7de1fa8f0eab1e0b4e24dbb181917aeeed891 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
@@ -173,7 +173,12 @@ UI.InspectorView = class extends UI.VBox {
* @param {string=} iconTooltip
*/
setPanelIcon(panelName, iconType, iconTooltip) {
dgozman 2016/12/20 05:42:04 Let's change this one to accept Icon instead.
lushnikov 2016/12/20 06:52:10 Done.
- this._tabbedPane.setTabIcon(panelName, iconType, iconTooltip);
+ var icon = null;
+ if (iconType) {
+ icon = UI.Icon.create(iconType);
+ icon.title = iconTooltip || '';
+ }
+ this._tabbedPane.setTabIcon(panelName, icon);
}
/**
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css » ('J')

Powered by Google App Engine
This is Rietveld 408576698