DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances

third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 273 matching lines @@
   }
 
   _recreateToolbarItems() {
     this._panelToolbar.removeToolbarItems();
 
     const perspectiveSetting =
         Common.settings.createSetting('timelinePerspective', Timeline.TimelinePanel.Perspectives.Load);
 
     // Record
     if (Runtime.experiments.isEnabled('timelineLandingPage')) {
-      const newButton = new UI.ToolbarButton(
-          Common.UIString('New recording'), 'largeicon-add', Common.UIString('New'));
+      const newButton = new UI.ToolbarButton(Common.UIString('New recording'), 'largeicon-add', Common.UIString('New'));
       newButton.addEventListener(UI.ToolbarButton.Events.Click, this._clear, this);
       this._panelToolbar.appendToolbarItem(newButton);
       this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButtonForId('main.reload'));
       this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._toggleRecordAction));
-    } else if (Runtime.experiments.isEnabled('timelineRecordingPerspectives') &&
+    } else if (
+        Runtime.experiments.isEnabled('timelineRecordingPerspectives') &&
         perspectiveSetting.get() === Timeline.TimelinePanel.Perspectives.Load) {
       const reloadButton = new UI.ToolbarButton(Common.UIString('Record & Reload'), 'largeicon-refresh');
       reloadButton.addEventListener(UI.ToolbarButton.Events.Click, () => SDK.targetManager.reloadPage());
       this._panelToolbar.appendToolbarItem(reloadButton);
     } else {
       this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._toggleRecordAction));
     }
 
     // Clear
     if (!Runtime.experiments.isEnabled('timelineLandingPage')) {
@@ skipping 60 matching lines @@
           break;
       }
 
       this._bulkUpdate = false;
       this._onModeChanged();
     }
 
     // Checkboxes
     if (Runtime.experiments.isEnabled('timelineLandingPage')) {
       if (!this._model.isEmpty()) {
-        this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Common.UIString('Memory'),
-            this._showMemorySetting, Common.UIString('Show memory timeline.')));
+        this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(
+            Common.UIString('Memory'), this._showMemorySetting, Common.UIString('Show memory timeline.')));
         if (this._filmStripModel.frames().length) {
           this._showScreenshotsSetting.set(true);
-          this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Common.UIString('Screenshots'),
-              this._showScreenshotsSetting, Common.UIString('Show captured screenshots.')));
+          this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(
+              Common.UIString('Screenshots'), this._showScreenshotsSetting,
+              Common.UIString('Show captured screenshots.')));
         }
       }
     } else {
       const screenshotCheckbox = this._createSettingCheckbox(
           Common.UIString('Screenshots'), this._captureFilmStripSetting,
           Common.UIString('Capture screenshots while recording. (Has small performance overhead)'));
 
       if (!Runtime.experiments.isEnabled('timelineRecordingPerspectives') ||
           perspectiveSetting.get() === Timeline.TimelinePanel.Perspectives.Custom) {
         this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(
@@ skipping 161 matching lines @@
   }
 
   _refreshViews() {
     this._currentViews.forEach(view => view.refreshRecords());
     this._updateSelectionDetails();
   }
 
   _onModeChanged() {
     if (this._bulkUpdate)
       return;
-    const showMemory = Runtime.experiments.isEnabled('timelineLandingPage')
-        ? this._showMemorySetting.get() : this._captureMemorySetting.get();
-    const showScreenshots = Runtime.experiments.isEnabled('timelineLandingPage')
-        ? this._showScreenshotsSetting.get() && this._filmStripModel.frames().length
-        : this._captureFilmStripSetting.get();
+    const showMemory = Runtime.experiments.isEnabled('timelineLandingPage') ? this._showMemorySetting.get() :
+                                                                              this._captureMemorySetting.get();
+    const showScreenshots = Runtime.experiments.isEnabled('timelineLandingPage') ?
+        this._showScreenshotsSetting.get() && this._filmStripModel.frames().length :
+        this._captureFilmStripSetting.get();
     // Set up overview controls.
     this._overviewControls = [];
     this._overviewControls.push(new Timeline.TimelineEventOverviewResponsiveness(this._model, this._frameModel));
     if (Runtime.experiments.isEnabled('inputEventsOnTimelineOverview'))
       this._overviewControls.push(new Timeline.TimelineEventOverviewInput(this._model));
     this._overviewControls.push(new Timeline.TimelineEventOverviewFrames(this._model, this._frameModel));
     this._overviewControls.push(new Timeline.TimelineEventOverviewCPUActivity(this._model));
     this._overviewControls.push(new Timeline.TimelineEventOverviewNetwork(this._model));
     if (showScreenshots)
       this._overviewControls.push(new Timeline.TimelineFilmStripOverview(this._model, this._filmStripModel));
     if (showMemory)
       this._overviewControls.push(new Timeline.TimelineEventOverviewMemory(this._model));
     this._overviewPane.setOverviewControls(this._overviewControls);
 
     // Set up the main view.
     this._removeAllModeViews();
     this._flameChart = new Timeline.TimelineFlameChartView(
         this, this._model, this._frameModel, this._irModel, this._extensionTracingModels, this._filters);
     this._flameChart.enableNetworkPane(this._captureNetworkSetting.get());
     this._addModeView(this._flameChart);
 
     if (showMemory) {
-      this._addModeView(new Timeline.MemoryCountersGraph(
-          this, this._model, [Timeline.TimelineUIUtils.visibleEventsFilter()]));
+      this._addModeView(
+          new Timeline.MemoryCountersGraph(this, this._model, [Timeline.TimelineUIUtils.visibleEventsFilter()]));
     }
     if (Runtime.experiments.isEnabled('timelineLandingPage'))
       this._flameChart.enableNetworkPane(true);
 
     this.doResize();
     this.select(null);
   }
 
   _onNetworkChanged() {
     if (this._flameChart)
@@ skipping 1445 matching lines @@
     this._throttlingRate = 1.;  // No throttling
     SDK.targetManager.observeTargets(this, SDK.Target.Capability.Browser);
   }
 
   /**
    * @param {number} value
    */
   setRate(value) {
     this._throttlingRate = value;
     this._targets.forEach(target => target.emulationAgent().setCPUThrottlingRate(value));
-    if (value !== 1)
-      UI.inspectorView.setPanelIcon('timeline', 'smallicon-warning', Common.UIString('CPU throttling is enabled'));
-    else
-      UI.inspectorView.setPanelIcon('timeline', '', '');
+    var icon = null;
+    if (value !== 1) {
+      icon = UI.Icon.create('smallicon-warning');
+      icon.title = Common.UIString('CPU throttling is enabled');
+    }
+    UI.inspectorView.setPanelIcon('timeline', icon);
   }
 
   /**
    * @return {number}
    */
   rate() {
     return this._throttlingRate;
   }
 
   /**
    * @override
    * @param {!SDK.Target} target
    */
   targetAdded(target) {
     this._targets.push(target);
     target.emulationAgent().setCPUThrottlingRate(this._throttlingRate);
   }
 
   /**
    * @override
    * @param {!SDK.Target} target
    */
   targetRemoved(target) {
     this._targets.remove(target, true);
   }
 };