third_party/WebKit/Source/core/layout/ng/ng_length_utils.h - Issue 2587283004: [layoutng] Add a shrink-to-fit flag to the constraint space

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

Issue 2587283004: [layoutng] Add a shrink-to-fit flag to the constraint space (Closed)

Patch Set: fix incorrect logic Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

index 9e67b620f09f9607457d2873379ce274d4a1daee..a53ba2e33cf2f8f8af0686efcecad24061194b2e 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

@@ -33,7 +33,8 @@ enum class LengthResolveType {

// pass them to ResolveInlineLength / ComputeInlineSizeForFragment.

// If this function returns false, it is safe to pass an empty

// MinAndMaxContentSizes struct to those functions.

-CORE_EXPORT bool NeedMinAndMaxContentSizes(const ComputedStyle&);

+CORE_EXPORT bool NeedMinAndMaxContentSizes(const NGConstraintSpace&,

+ const ComputedStyle&);

// Like NeedMinAndMaxContentSizes, but for use when calling

// ComputeMinAndMaxContentContribution.