Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

Issue 2587283004: [layoutng] Add a shrink-to-fit flag to the constraint space (Closed)
Patch Set: fix incorrect logic Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
index a392af7a46970f2588c750f74ebaa5bb253669eb..cf836bdf882d9c94c144080ab85e616a50270d1c 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
@@ -94,6 +94,8 @@ class CORE_EXPORT NGConstraintSpace final
bool IsFixedSizeBlock() const { return is_fixed_size_block_; }
+ bool HasForcedShrinkToFit() const { return has_forced_shrink_to_fit_; }
ikilpatrick 2016/12/22 00:06:14 Comment explaining what this does? E.g. Whether t
ikilpatrick 2016/12/22 00:06:14 IsShrinkToFit? to keep in line with other bits?
cbiesinger 2016/12/22 03:34:25 Done (both).
+
// If specified a layout should produce a Fragment which fragments at the
// blockSize if possible.
NGFragmentationType BlockFragmentationType() const;
@@ -120,6 +122,7 @@ class CORE_EXPORT NGConstraintSpace final
NGLogicalSize percentage_resolution_size,
bool is_fixed_size_inline,
bool is_fixed_size_block,
+ bool has_forced_shrink_to_fit,
bool is_inline_direction_triggers_scrollbar,
bool is_block_direction_triggers_scrollbar,
NGFragmentationType block_direction_fragmentation_type,
@@ -132,6 +135,8 @@ class CORE_EXPORT NGConstraintSpace final
unsigned is_fixed_size_inline_ : 1;
unsigned is_fixed_size_block_ : 1;
+ unsigned has_forced_shrink_to_fit_ : 1;
+
unsigned is_inline_direction_triggers_scrollbar_ : 1;
unsigned is_block_direction_triggers_scrollbar_ : 1;

Powered by Google App Engine
This is Rietveld 408576698