Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Unified Diff: net/cert/ocsp_verify_result.h

Issue 2587243002: Do not do Expect-Staple when OCSPVerifyResult has not been populated (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/transport_security_state.cc » ('j') | net/http/transport_security_state.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ocsp_verify_result.h
diff --git a/net/cert/ocsp_verify_result.h b/net/cert/ocsp_verify_result.h
index a4dc71e80e2dda65e373efed02fc5b2675613df5..66ab4c2f494c214296e385a3367d101ad8601f90 100644
--- a/net/cert/ocsp_verify_result.h
+++ b/net/cert/ocsp_verify_result.h
@@ -27,6 +27,9 @@ struct NET_EXPORT OCSPVerifyResult {
bool operator==(const OCSPVerifyResult& other) const;
enum ResponseStatus {
+ // OCSP verification was not checked on this connection.
+ UNKNOWN,
Ryan Sleevi 2016/12/21 01:35:29 The risk of "Unknown" here is that it might become
estark 2016/12/21 17:53:12 NOT_CHECKED seems reasonable, done.
+
// No OCSPResponse was stapled.
MISSING,
@@ -56,7 +59,7 @@ struct NET_EXPORT OCSPVerifyResult {
};
- ResponseStatus response_status = MISSING;
+ ResponseStatus response_status = UNKNOWN;
// The strictest CertStatus matching the certificate (REVOKED > UNKNOWN >
// GOOD). Only valid if |response_status| = PROVIDED.
« no previous file with comments | « no previous file | net/http/transport_security_state.cc » ('j') | net/http/transport_security_state.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698