pkg/dev_compiler/test/browser/language_tests.js - Issue 2587203002: Correct handling of cross-frame functions in ddc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2587203002: Correct handling of cross-frame functions in ddc. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/test/browser/language_tests.js

diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js

index 2e2c6d4127b11838cd9c15f844224441ba51a4b3..9415742a71dc727de2a5dc2230a6d38ea1451841 100644

--- a/pkg/dev_compiler/test/browser/language_tests.js

+++ b/pkg/dev_compiler/test/browser/language_tests.js

@@ -471,8 +471,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],

'interactive_test': async_unittest,

'isolates_test': async_unittest,

- // Failing on "identical JS objects should have identical proxies".

- 'js_test': 'fail',

+ // 'js_test': 'fail',

Bob Nystrom 2016/12/19 22:23:42 Just delete the line.

Jacob 2016/12/19 22:38:13 doh. done.

'js_interop_1_test': async_unittest,

// Failing because accessing "zSomeInvalidName" does not throw.