Correct handling of cross-frame functions in ddc.

tests/lib_strong/html/js_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:html';
-import 'dart:typed_data' show ByteBuffer, Int32List;
+import 'dart:typed_data' show Int32List;
 import 'dart:indexed_db' show IdbFactory, KeyRange;
 import 'dart:js';
+import 'package:js/js_util.dart' as js_util;
 
 import 'package:expect/minitest.dart';
 
 _injectJs() {
   final script = new ScriptElement();
   script.type = 'text/javascript';
   script.innerHtml = r"""
 var x = 42;
 
 var _x = 123;
@@ skipping 482 matching lines @@
       expect(context.callMethod('isPropertyInstanceOf',
           ['a', context['Array']]), isTrue);
       var a = context['a'];
       expect(a is JsArray, isTrue);
       expect(a, [1, 2, 3]);
       context.deleteProperty('a');
     });
 
     test('pass Array to JS', () {
       context['a'] = [1, 2, 3];
-      expect(context.callMethod('isPropertyInstanceOf',
-          ['a', context['Array']]), isTrue);
       var a = context['a'];
       expect(a is List, isTrue);
       expect(a is JsArray, isFalse);
       expect(a, [1, 2, 3]);
       context.deleteProperty('a');
     });
 
     test('[]', () {
       var array = new JsArray.from([1, 2]);
       expect(array[0], 1);
@@ skipping 312 matching lines @@
 
       test('DateTime', () {
         var date = context.callMethod('getNewDate');
         expect(date is DateTime, isTrue);
       });
 
       test('window', () {
         expect(context['window'] is Window, isTrue);
       });
 
-      // Bug: dartbug.com/24520
-      /*
       test('foreign browser objects should be proxied', () {
         var iframe = new IFrameElement();
         document.body.children.add(iframe);
         var proxy = new JsObject.fromBrowserObject(iframe);
 
         // Window
         var contentWindow = proxy['contentWindow'];
-        expect(contentWindow, isNot(new isInstanceOf<Window>()));
-        expect(contentWindow, new isInstanceOf<JsObject>());
+        expect(contentWindow is! Window, isTrue);
+        expect(contentWindow is JsObject, isTrue);
 
         // Node
         var foreignDoc = contentWindow['document'];
-        expect(foreignDoc, isNot(new isInstanceOf<Node>()));
-        expect(foreignDoc, new isInstanceOf<JsObject>());
+        expect(foreignDoc is! Node, isTrue);
+        expect(foreignDoc is JsObject, isTrue);
 
         // Event
         var clicked = false;
         foreignDoc['onclick'] = (e) {
-          expect(e, isNot(new isInstanceOf<Event>()));
-          expect(e, new isInstanceOf<JsObject>());
+          expect(e is! Event, isTrue);
+          expect(e is JsObject, isTrue);
           clicked = true;
         };
 
         context.callMethod('fireClickEvent', [contentWindow]);
         expect(clicked, isTrue);
       });
-      */
+
+      test('foreign functions pass function is checks', () {
+        var iframe = new IFrameElement();
+        document.body.children.add(iframe);
+        var proxy = new JsObject.fromBrowserObject(iframe);
+
+        var contentWindow = proxy['contentWindow'];
+        var foreignDoc = contentWindow['document'];
+
+        // Function
+        var foreignFunction = foreignDoc['createElement'];
+        expect(foreignFunction is JsFunction, isTrue);
+
+        // Verify that internal isChecks in callMethod work.
+        foreignDoc.callMethod('createElement', ['div']);
+
+        var typedContentWindow = js_util.getProperty(iframe, 'contentWindow');
+        var typedForeignDoc = js_util.getProperty(typedContentWindow, 'document');
+
+        var typedForeignFunction = js_util.getProperty(typedForeignDoc, 'createElement');
+        expect(typedForeignFunction is Function, isTrue);
+        js_util.callMethod(typedForeignDoc, 'createElement', ['div']);
+      });
 
       test('document', () {
         expect(context['document'] is Document, isTrue);
       });
 
       skipIE9_test('Blob', () {
         var blob = context.callMethod('getNewBlob');
         expect(blob is Blob, isTrue);
         expect(blob.type, equals('text/html'));
       });
@@ skipping 114 matching lines @@
           // expect(context.callMethod('isPropertyInstanceOf', ['o', listType]),
           //    isTrue);
           context.deleteProperty('o');
         }
       });
 
     });
   });
 
 }