Cleanup NetworkActivityIndicatorTabHelper and add unittest.

ios/chrome/browser/web/network_activity_indicator_tab_helper.mm

Index: ios/chrome/browser/web/network_activity_indicator_tab_helper.mm
diff --git a/ios/chrome/browser/web/network_activity_indicator_tab_helper.mm b/ios/chrome/browser/web/network_activity_indicator_tab_helper.mm
index 7734e77e7d2f7f1e36b03fa1c8d0e0b0869eb359..0d6635d591465f38dd82f0b8f93353ddc8d9f1a3 100644
--- a/ios/chrome/browser/web/network_activity_indicator_tab_helper.mm
+++ b/ios/chrome/browser/web/network_activity_indicator_tab_helper.mm
@@ -26,12 +26,7 @@ NetworkActivityIndicatorTabHelper::NetworkActivityIndicatorTabHelper(
     : web::WebStateObserver(web_state), network_activity_key_([tab_id copy]) {}
 
 NetworkActivityIndicatorTabHelper::~NetworkActivityIndicatorTabHelper() {
-  NetworkActivityIndicatorManager* shared_manager =
-      [NetworkActivityIndicatorManager sharedInstance];
-  // Verifies that there is a network task associated with this instance
-  // before stopping a task, so that this method is idempotent.
-  if ([shared_manager numNetworkTasksForGroup:network_activity_key_])
-    [shared_manager stopNetworkTaskForGroup:network_activity_key_];
+  Stop();
 }
 
 void NetworkActivityIndicatorTabHelper::DidStartLoading() {
@@ -44,6 +39,10 @@ void NetworkActivityIndicatorTabHelper::DidStartLoading() {
 }
 
 void NetworkActivityIndicatorTabHelper::DidStopLoading() {
+  Stop();
+}
+
+void NetworkActivityIndicatorTabHelper::Stop() {

[Eugene But (OOO till 7-30), 2016/12/19 20:53:01]

nit: Could you please keep the same method order as in the header (I guess
changing the header is simpler).

[michaeldo, 2016/12/19 21:43:44]

Fixed.

   NetworkActivityIndicatorManager* shared_manager =
       [NetworkActivityIndicatorManager sharedInstance];
   // Verifies that there is a network task associated with this instance