Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 258713002: Linux Aura: get tooltip background color from theme (Closed)

Created:
6 years, 8 months ago by Evan Stade
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, ben+corewm_chromium.org
Visibility:
Public.

Description

Linux Aura: get tooltip background color from theme the border color can still conflict with the theme (e.g., no visible border if the tooltip bg is dark), but fixing that is a lot harder because the border, window roundedness, and shadow are all one tiled set of images (see shadow.cc). BUG=348194 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266974 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/native_theme/fallback_theme.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
Evan Stade
6 years, 8 months ago (2014-04-24 20:27:49 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 8 months ago (2014-04-25 15:51:11 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-25 19:04:23 UTC) #3
Evan Stade
The CQ bit was unchecked by estade@chromium.org
6 years, 8 months ago (2014-04-25 21:15:48 UTC) #4
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-25 21:15:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/258713002/1
6 years, 8 months ago (2014-04-25 22:01:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:19:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 23:19:43 UTC) #8
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 7 months ago (2014-04-28 22:42:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/258713002/1
6 years, 7 months ago (2014-04-28 22:42:53 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 23:41:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 23:41:31 UTC) #12
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 7 months ago (2014-04-29 16:48:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/258713002/1
6 years, 7 months ago (2014-04-29 16:49:14 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 17:39:01 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 17:39:02 UTC) #16
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 7 months ago (2014-04-29 19:23:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/258713002/1
6 years, 7 months ago (2014-04-29 19:27:15 UTC) #18
commit-bot: I haz the power
Change committed as 266974
6 years, 7 months ago (2014-04-29 22:15:36 UTC) #19
robliao
A revert of this CL has been created in https://codereview.chromium.org/263533003/ by robliao@chromium.org. The reason for ...
6 years, 7 months ago (2014-04-29 23:12:05 UTC) #20
robliao
The CQ bit was checked by robliao@chromium.org
6 years, 7 months ago (2014-04-30 00:04:54 UTC) #21
robliao
On 2014/04/30 00:04:54, robliao wrote: > The CQ bit was checked by mailto:robliao@chromium.org Relanding as ...
6 years, 7 months ago (2014-04-30 00:05:35 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/258713002/1
6 years, 7 months ago (2014-04-30 00:07:57 UTC) #23
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 00:10:25 UTC) #24
Message was sent while issue was closed.
Change committed as 267000

Powered by Google App Engine
This is Rietveld 408576698