Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2587083002: Media Controls: add comments regarding cast/remote related calls from element. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/shadow/MediaControls.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.h b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
index 5112210f4c3a7b180a07304b49295f12396858b9..2b520c58f1fb7feb9c5d0fc110986ee6f751af63 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
@@ -65,9 +65,6 @@ class CORE_EXPORT MediaControls final : public HTMLDivElement {
void enteredFullscreen();
void exitedFullscreen();
- void startedCasting();
- void stoppedCasting();
- void refreshCastButtonVisibility();
void showOverlayCastButtonIfNeeded();
// Update cast button visibility, but don't try to update our panel
// button visibility for space.
@@ -103,6 +100,18 @@ class CORE_EXPORT MediaControls final : public HTMLDivElement {
// be notified on the TextTrack object. See https://crbug.com/669977
void onTrackElementFailedToLoad() { onTextTracksAddedOrRemoved(); }
+ // TODO(mlamouri): the following methods will be able to become private when
+ // the controls have moved to modules/ and have access to RemotePlayback.
+ void onRemotePlaybackAvailabilityChanged() { refreshCastButtonVisibility(); }
+ void onRemotePlaybackConnecting() { startedCasting(); }
+ void onRemotePlaybackDisconnected() { stoppedCasting(); }
+
+ // TODO(mlamouri): this method is needed in order to notify the controls that
+ // the attribute have changed.
+ void onDisableRemotePlaybackAttributeChanged() {
+ refreshCastButtonVisibility();
+ }
+
DECLARE_VIRTUAL_TRACE();
private:
@@ -163,6 +172,11 @@ class CORE_EXPORT MediaControls final : public HTMLDivElement {
void onError();
void onLoadedMetadata();
+ // Internal cast related methods.
+ void startedCasting();
+ void stoppedCasting();
+ void refreshCastButtonVisibility();
+
Member<HTMLMediaElement> m_mediaElement;
// Media control elements.
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698