Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller_unittest.mm

Issue 2587023002: Upstream Chrome on iOS source code [8/11]. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..b7317e22c14b91a0497a66d4ce7182deba56ecdd
--- /dev/null
+++ b/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller_unittest.mm
@@ -0,0 +1,238 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.h"
+
+#import <UIKit/UIKit.h>
+
+#include <memory>
+
+#include "base/compiler_specific.h"
+#include "base/mac/scoped_nsobject.h"
+#include "base/memory/ptr_util.h"
+#include "base/message_loop/message_loop.h"
+#include "base/strings/sys_string_conversions.h"
+#import "base/test/ios/wait_util.h"
+#include "components/browser_sync/profile_sync_service_mock.h"
+#include "components/strings/grit/components_strings.h"
+#include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
+#include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h"
+#include "ios/chrome/browser/sync/sync_setup_service.h"
+#include "ios/chrome/browser/sync/sync_setup_service_factory.h"
+#include "ios/chrome/browser/sync/sync_setup_service_mock.h"
+#import "ios/chrome/browser/ui/settings/cells/byo_textfield_item.h"
+#import "ios/chrome/browser/ui/settings/cells/card_multiline_item.h"
+#include "ios/chrome/browser/ui/settings/passphrase_collection_view_controller_test.h"
+#import "ios/chrome/browser/ui/sync/sync_util.h"
+#include "testing/gtest_mac.h"
+#include "testing/platform_test.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/l10n/l10n_util_mac.h"
+
+namespace {
+
+using testing::_;
+using testing::AtLeast;
+using testing::NiceMock;
+using testing::Return;
+
+class SyncEncryptionPassphraseCollectionViewControllerTest
+ : public PassphraseCollectionViewControllerTest {
+ public:
+ SyncEncryptionPassphraseCollectionViewControllerTest() {}
+
+ static std::unique_ptr<KeyedService> CreateSyncSetupService(
+ web::BrowserState* context) {
+ ios::ChromeBrowserState* chrome_browser_state =
+ ios::ChromeBrowserState::FromBrowserState(context);
+ syncer::SyncService* sync_service =
+ IOSChromeProfileSyncServiceFactory::GetForBrowserState(
+ chrome_browser_state);
+ return base::MakeUnique<SyncSetupServiceMock>(
+ sync_service, chrome_browser_state->GetPrefs());
+ }
+
+ void TurnSyncPassphraseErrorOn() {
+ ON_CALL(*mock_sync_setup_service_, GetSyncServiceState())
+ .WillByDefault(Return(SyncSetupService::kSyncServiceNeedsPassphrase));
+ }
+
+ void TurnSyncOtherErrorOn(SyncSetupService::SyncServiceState state) {
+ ON_CALL(*mock_sync_setup_service_, GetSyncServiceState())
+ .WillByDefault(Return(state));
+ }
+
+ void TurnSyncErrorOff() {
+ ON_CALL(*mock_sync_setup_service_, GetSyncServiceState())
+ .WillByDefault(Return(SyncSetupService::kNoSyncServiceError));
+ }
+
+ protected:
+ void SetUp() override {
+ PassphraseCollectionViewControllerTest::SetUp();
+ mock_sync_setup_service_ = static_cast<NiceMock<SyncSetupServiceMock>*>(
+ SyncSetupServiceFactory::GetInstance()->SetTestingFactoryAndUse(
+ chrome_browser_state_.get(), &CreateSyncSetupService));
+ // The other mocked functions of SyncSetupServiceMock return bools, so they
+ // will by default return false. GetSyncServiceState(), however, returns an
+ // enum, and thus always needs its default value set.
+ TurnSyncErrorOff();
+ };
+
+ void TearDown() override {
+ [SyncController() stopObserving];
+ PassphraseCollectionViewControllerTest::TearDown();
+ }
+
+ CollectionViewController* NewController() override NS_RETURNS_RETAINED {
+ return [[SyncEncryptionPassphraseCollectionViewController alloc]
+ initWithBrowserState:chrome_browser_state_.get()];
+ }
+
+ SyncEncryptionPassphraseCollectionViewController* SyncController() {
+ return static_cast<SyncEncryptionPassphraseCollectionViewController*>(
+ controller());
+ }
+
+ // Weak, owned by |profile_|.
+ NiceMock<SyncSetupServiceMock>* mock_sync_setup_service_;
+};
+
+TEST_F(SyncEncryptionPassphraseCollectionViewControllerTest, TestModel) {
+ SyncEncryptionPassphraseCollectionViewController* controller =
+ SyncController();
+ EXPECT_EQ(2, NumberOfSections());
+ EXPECT_EQ(2, NumberOfItemsInSection(0));
+ // Passphrase message item.
+ CardMultilineItem* item = GetCollectionViewItem(0, 0);
+ EXPECT_NSEQ(l10n_util::GetNSString(IDS_SYNC_ENTER_GOOGLE_PASSPHRASE_BODY),
+ item.text);
+ // Passphrase items.
+ BYOTextFieldItem* passphraseItem = GetCollectionViewItem(0, 1);
+ EXPECT_NSEQ(controller.passphrase, passphraseItem.textField);
+}
+
+TEST_F(SyncEncryptionPassphraseCollectionViewControllerTest,
+ TestConstructorDestructor) {
+ CreateController();
+ CheckController();
+ EXPECT_CALL(*fake_sync_service_, SetDecryptionPassphrase(_)).Times(0);
+ // Simulate the view appearing.
+ [controller() viewWillAppear:YES];
+ [controller() viewDidAppear:YES];
+}
+
+TEST_F(SyncEncryptionPassphraseCollectionViewControllerTest,
+ TestDecryptButton) {
+ SyncEncryptionPassphraseCollectionViewController* sync_controller =
+ SyncController();
+ [sync_controller textFieldDidChange:[sync_controller passphrase]];
+ EXPECT_FALSE([[sync_controller navigationItem].rightBarButtonItem isEnabled]);
+ [[sync_controller passphrase] setText:@"decodeme"];
+ [sync_controller textFieldDidChange:[sync_controller passphrase]];
+ EXPECT_TRUE([[sync_controller navigationItem].rightBarButtonItem isEnabled]);
+}
+
+TEST_F(SyncEncryptionPassphraseCollectionViewControllerTest,
+ TestDecryptWrongPassphrase) {
+ SyncEncryptionPassphraseCollectionViewController* sync_controller =
+ SyncController();
+ EXPECT_CALL(*fake_sync_service_, AddObserver(_)).Times(AtLeast(1));
+ EXPECT_CALL(*fake_sync_service_, RemoveObserver(_)).Times(AtLeast(1));
+ EXPECT_CALL(*fake_sync_service_, SetDecryptionPassphrase(_));
+ [[sync_controller passphrase] setText:@"decodeme"];
+ // Set the return value for setting the passphrase to failure.
+ ON_CALL(*fake_sync_service_, SetDecryptionPassphrase(_))
+ .WillByDefault(Return(false));
+ [sync_controller signInPressed];
+}
+
+TEST_F(SyncEncryptionPassphraseCollectionViewControllerTest,
+ TestDecryptCorrectPassphrase) {
+ SyncEncryptionPassphraseCollectionViewController* sync_controller =
+ SyncController();
+ EXPECT_CALL(*fake_sync_service_, AddObserver(_)).Times(AtLeast(1));
+ EXPECT_CALL(*fake_sync_service_, RemoveObserver(_)).Times(AtLeast(1));
+ EXPECT_CALL(*fake_sync_service_, SetDecryptionPassphrase(_));
+ [[sync_controller passphrase] setText:@"decodeme"];
+ // Set the return value for setting the passphrase to success.
+ ON_CALL(*fake_sync_service_, SetDecryptionPassphrase(_))
+ .WillByDefault(Return(true));
+ [sync_controller signInPressed];
+}
+
+TEST_F(SyncEncryptionPassphraseCollectionViewControllerTest,
+ TestOnStateChangedWrongPassphrase) {
+ SyncEncryptionPassphraseCollectionViewController* sync_controller =
+ SyncController();
+ // Sets up a UINavigationController that has |controller_| as the second view
+ // controller on the navigation stack.
+ SetUpNavigationController(sync_controller);
+ EXPECT_EQ([nav_controller_ topViewController], sync_controller);
+
+ // Set up the fake sync service to still require the passphrase.
+ ON_CALL(*fake_sync_service_, IsPassphraseRequired())
+ .WillByDefault(Return(true));
+ [sync_controller onSyncStateChanged];
+ // The controller should only reload. Because there is text in the passphrase
+ // field, the 'ok' button should be enabled.
+ EXPECT_EQ([nav_controller_ topViewController], sync_controller);
+}
+
+TEST_F(SyncEncryptionPassphraseCollectionViewControllerTest,
+ TestOnStateChangedCorrectPassphrase) {
+ SyncEncryptionPassphraseCollectionViewController* sync_controller =
+ SyncController();
+ // Sets up a UINavigationController that has |controller_| as the second view
+ // controller on the navigation stack.
+ SetUpNavigationController(sync_controller);
+ EXPECT_EQ([nav_controller_ topViewController], sync_controller);
+
+ // Set up the fake sync service to have accepted the passphrase.
+ ON_CALL(*fake_sync_service_, IsPassphraseRequired())
+ .WillByDefault(Return(false));
+ ON_CALL(*fake_sync_service_, IsUsingSecondaryPassphrase())
+ .WillByDefault(Return(true));
+ [sync_controller onSyncStateChanged];
+ // Calling -onStateChanged with an accepted secondary passphrase should
+ // cause the controller to be popped off the navigation stack.
+ base::test::ios::WaitUntilCondition(^bool() {
+ return [nav_controller_ topViewController] != sync_controller;
+ });
+ EXPECT_NE([nav_controller_ topViewController], sync_controller);
+}
+
+TEST_F(SyncEncryptionPassphraseCollectionViewControllerTest, TestMessage) {
+ SyncEncryptionPassphraseCollectionViewController* sync_controller =
+ SyncController();
+ // Default.
+ EXPECT_FALSE([sync_controller syncErrorMessage]);
+
+ SyncSetupService::SyncServiceState otherState =
+ SyncSetupService::kSyncServiceSignInNeedsUpdate;
+
+ // With a custom message.
+ [sync_controller setSyncErrorMessage:@"message"];
+ EXPECT_NSEQ(@"message", [sync_controller syncErrorMessage]);
+ TurnSyncPassphraseErrorOn();
+ EXPECT_NSEQ(@"message", [sync_controller syncErrorMessage]);
+ TurnSyncOtherErrorOn(otherState);
+ EXPECT_NSEQ(@"message", [sync_controller syncErrorMessage]);
+ TurnSyncErrorOff();
+ EXPECT_NSEQ(@"message", [sync_controller syncErrorMessage]);
+
+ // With no custom message.
+ [sync_controller setSyncErrorMessage:nil];
+ EXPECT_FALSE([sync_controller syncErrorMessage]);
+ TurnSyncPassphraseErrorOn();
+ EXPECT_FALSE([sync_controller syncErrorMessage]);
+ TurnSyncOtherErrorOn(otherState);
+ EXPECT_NSEQ(ios_internal::sync::GetSyncErrorMessageForBrowserState(
+ chrome_browser_state_.get()),
+ [sync_controller syncErrorMessage]);
+ TurnSyncErrorOff();
+ EXPECT_FALSE([sync_controller syncErrorMessage]);
+}
+
+} // namespace

Powered by Google App Engine
This is Rietveld 408576698