Issue 258693012: Add BatteryStatusEventPump in Chromium for sending Battery status events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258693012: Add BatteryStatusEventPump in Chromium for sending Battery status events

Created:
6 years, 7 months ago by Srini

Modified:
6 years, 7 months ago

Reviewers:
timvolodine

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add BatteryStatusEventPump in Chromium for sending Battery status events to blink::WebBatteryStatusListener BUG=122593

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -0 lines)			Patch
M	content/content_renderer.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	content/renderer/battery_status/battery_status_event_pump.h	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	content/renderer/battery_status/battery_status_event_pump.cc	View	1 chunk	+33 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.h	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Srini

Hi Tim, Can you review this? (And add who is the right owner to approve ...

6 years, 7 months ago (2014-04-28 17:36:45 UTC) #1

timvolodine

On 2014/04/28 17:36:45, Srini wrote: > Hi Tim, > > Can you review this? (And ...

6 years, 7 months ago (2014-04-28 17:45:27 UTC) #2

Srini

6 years, 7 months ago (2014-05-19 06:55:21 UTC) #3

On 2014/04/28 17:45:27, timvolodine wrote:
> On 2014/04/28 17:36:45, Srini wrote:
> > Hi Tim,
> > 
> > Can you review this? (And add who is the right owner to approve it?.)
> > 
> > Thanks,
> > -Srini
> 
> Please hold with this patch. We are currently waiting for reply from mozilla
to
> decide how to proceed. Also as already noted on blink-dev I will be doing the
> chromium side implementation as I already have most of the code for this.

Tim,

Just want to poke on how the progress on the spec is happening. Let me know if
you want some help here.

Thanks,
-Srini.

Expand Messages | Collapse Messages