Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: mojo/spy/spy.h

Issue 258693011: First cut at mojo spy's websocket server (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: lf Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/spy/DEPS ('k') | mojo/spy/spy.cc » ('j') | mojo/spy/spy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/spy/spy.h
diff --git a/mojo/spy/spy.h b/mojo/spy/spy.h
index 0636004ba5fd8b78c9c727d0a36628f1868c2987..8095beebac3dd178307ae4390fe8321549154741 100644
--- a/mojo/spy/spy.h
+++ b/mojo/spy/spy.h
@@ -6,15 +6,34 @@
#define MOJO_SPY_SPY_H_
#include <string>
+#include "base/memory/scoped_ptr.h"
+
+namespace base {
+ class Thread;
darin (slow to review) 2014/04/29 06:03:58 nit: no indent
cpu_(ooo_6.6-7.5) 2014/04/29 22:31:16 Done.
+}
namespace mojo {
class ServiceManager;
+// mojo::Spy is a troubleshooting and debugging aid. It helps tracking
+// the mojo system core activities like messages, service creation, etc.
+// Very much a work in progress at this time.
darin (slow to review) 2014/04/29 06:03:58 nit: I'd probably leave out this last sentence as
cpu_(ooo_6.6-7.5) 2014/04/29 22:31:16 Done.
+//
+// The |options| parameter in the constructor comes from the command
+// line of the mojo_shell. Which takes --spy=<options>. Each option is
+// separated by ',' and each option is a key+ value pair separated by ':'.
+//
+// For example --spy=port:13333
+//
class Spy {
public:
Spy(mojo::ServiceManager* service_manager, const std::string& options);
~Spy();
+
+ private:
+ // This thread runs the code that talks to the frontend.
+ scoped_ptr<base::Thread> control_thread_;
};
} // namespace mojo
« no previous file with comments | « mojo/spy/DEPS ('k') | mojo/spy/spy.cc » ('j') | mojo/spy/spy.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698