First cut at mojo spy's websocket server

First cut at mojo spy's websocket server

Here we just add the websocket code with no interoperation with the
rest of the mojo spy. Basically necessary boilerplate.

Also a simple websocket client html file. Given mojo_shell.exe with:

--spy --origin=http://127.0.0.1:4444 --disable-cache mojo:mojo_sample_app

The webpage should be able to connect to the mojo spy via websocket.

BUG=360188
TEST= see spy_repl_test.html

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267132

[cpu_(ooo_6.6-7.5), 2014-04-26 23:42:44]

please take a look.

[darin (slow to review), 2014-04-29 06:03:58]

LGTM

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.cc
File mojo/spy/spy.cc (right):

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.cc#newcode172
mojo/spy/spy.cc:172: : websocket_port(kDefaultWebSocketPort) {
nit: indentation

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.cc#newcode181
mojo/spy/spy.cc:181: base::SplitStringIntoKeyValuePairs(options, ':',',',
&kv_pairs);
nit: add space after ':',

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.cc#newcode200
mojo/spy/spy.cc:200: control_thread_.reset(new
base::Thread("spy_control_thread"));
nit: add "mojo" to the prefix of this thread name?

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.h
File mojo/spy/spy.h (right):

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.h#newcode12
mojo/spy/spy.h:12: class Thread;
nit: no indent

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.h#newcode21
mojo/spy/spy.h:21: // Very much a work in progress at this time.
nit: I'd probably leave out this last sentence as it may bit-rot easily :)

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/test/spy_repl_t...
File mojo/spy/test/spy_repl_test.html (right):

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/test/spy_repl_t...
mojo/spy/test/spy_repl_test.html:64: el.attachEvent('on' + type, function () {
return fn.call(el, window.event); });
I think IE9 and later support addEventListener. Also, it looks like IE10 was the
first version of IE to support WebSockets. Maybe just design this page for
modern browsers?

[cpu_(ooo_6.6-7.5), 2014-04-29 22:31:16]

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.cc
File mojo/spy/spy.cc (right):

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.cc#newcode172
mojo/spy/spy.cc:172: : websocket_port(kDefaultWebSocketPort) {
On 2014/04/29 06:03:58, darin wrote:
> nit: indentation

Done.

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.cc#newcode181
mojo/spy/spy.cc:181: base::SplitStringIntoKeyValuePairs(options, ':',',',
&kv_pairs);
On 2014/04/29 06:03:58, darin wrote:
> nit: add space after ':',

Done.

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.cc#newcode200
mojo/spy/spy.cc:200: control_thread_.reset(new
base::Thread("spy_control_thread"));
On 2014/04/29 06:03:58, darin wrote:
> nit: add "mojo" to the prefix of this thread name?

Done.

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.h
File mojo/spy/spy.h (right):

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.h#newcode12
mojo/spy/spy.h:12: class Thread;
On 2014/04/29 06:03:58, darin wrote:
> nit: no indent

Done.

https://codereview.chromium.org/258693011/diff/20001/mojo/spy/spy.h#newcode21
mojo/spy/spy.h:21: // Very much a work in progress at this time.
On 2014/04/29 06:03:58, darin wrote:
> nit: I'd probably leave out this last sentence as it may bit-rot easily :)

Done.

[cpu_(ooo_6.6-7.5), 2014-04-29 22:32:45]

The CQ bit was checked by cpu@chromium.org

[commit-bot: I haz the power, 2014-04-29 22:34:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cpu@chromium.org/258693011/40001

[commit-bot: I haz the power, 2014-04-30 08:07:51]

Change committed as 267132