Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: tests/RecordDrawTest.cpp

Issue 258693006: Start using type traits in src/record instead of macros. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: ben Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/utils/SkTLogic.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/RecordDrawTest.cpp
diff --git a/tests/RecordDrawTest.cpp b/tests/RecordDrawTest.cpp
index 4f24c92fe59e396b20a32e67f7c90ad7e768859f..8c6635489e16f61e1ac3bbc40266bc43cfd380ab 100644
--- a/tests/RecordDrawTest.cpp
+++ b/tests/RecordDrawTest.cpp
@@ -50,14 +50,13 @@ DEF_TEST(RecordDraw_Clipping, r) {
SkRecord record;
SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, W, H);
- // 9 draw commands.
+ // 8 draw commands.
recorder.save();
recorder.clipRect(SkRect::MakeLTRB(0, 0, 100, 100));
recorder.drawRect(SkRect::MakeLTRB(20, 20, 40, 40), SkPaint());
recorder.save();
- // This first clipRect makes the clip empty, so the next two commands do nothing.
+ // This clipRect makes the clip empty, so the next command does nothing.
recorder.clipRect(SkRect::MakeLTRB(200, 200, 300, 300));
- recorder.clipRect(SkRect::MakeLTRB(210, 210, 250, 250)); // Skipped
recorder.drawRect(SkRect::MakeLTRB(220, 220, 240, 240), SkPaint()); // Skipped
recorder.restore();
recorder.restore();
@@ -67,6 +66,6 @@ DEF_TEST(RecordDraw_Clipping, r) {
SkRecorder rerecorder(SkRecorder::kReadWrite_Mode, &rerecord, W, H);
SkRecordDraw(record, &rerecorder);
- // All commands except the two marked // Skipped above will be preserved.
+ // All commands except the one marked // Skipped will be preserved.
REPORTER_ASSERT(r, 7 == rerecord.count());
}
« no previous file with comments | « src/utils/SkTLogic.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698