Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 2586883002: binding: Removes dead code in WindowProxy::createContext(). (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
index ea3eb2be02594c9960ff10f840ae5001e5ed2b73..fa2a6818da952bcdd5a0aa1b3167688590a552e1 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
@@ -291,21 +291,6 @@ bool WindowProxy::initialize() {
}
void WindowProxy::createContext() {
- // FIXME: This should be a null check of m_frame->client(), but there are
- // still some edge cases
- // that this fails to catch during frame detach.
- if (m_frame->isLocalFrame() &&
- !toLocalFrame(m_frame)->loader().documentLoader()) {
- // TODO(yukishiino): Remove this if-clause entirely once we are sure that
- // it's safe. There seems no case that we hit this if-clause. Plus,
- // createContext() is responsible just to create a new v8::Context, and it's
- // technically possible to create it without a document loader.
- // If we really want to limit the context creation under some condition,
- // it must come with the right reason described in a comment.
- NOTREACHED();
- return;
- }
-
// Create a new v8::Context with the window object as the global object
// (aka the inner global). Reuse the global proxy object (aka the outer
// global) if it already exists. See the comments in
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698