content/renderer/shared_worker/shared_worker_repository.cc - Issue 2586863002: Worker: Enable UseCounter for SharedWorkerGlobalScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/shared_worker/shared_worker_repository.cc

Issue 2586863002: Worker: Enable UseCounter for SharedWorkerGlobalScope (Closed)

Patch Set: address review comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/shared_worker/shared_worker_repository.cc

diff --git a/content/renderer/shared_worker/shared_worker_repository.cc b/content/renderer/shared_worker/shared_worker_repository.cc

index dfbcf70ad895006bd5d9a27225258b45c81ef123..fe5c846d282851941ba3797cbade718debfddf02 100644

--- a/content/renderer/shared_worker/shared_worker_repository.cc

+++ b/content/renderer/shared_worker/shared_worker_repository.cc

@@ -39,7 +39,7 @@ void SharedWorkerRepository::connect(

params.creation_context_type = creation_context_type;

ViewHostMsg_CreateWorker_Reply reply;

- // This proxy will self-destruct when a connection is established.

+ // This proxy will self-destruct when a worker is destroyed.

new WebSharedWorkerProxy(std::move(listener), params, channel);

}