Worker: Enable UseCounter for SharedWorkerGlobalScope

third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 204 matching lines @@
     loadShadowPage();
 }
 
 WebDevToolsAgentClient::WebKitClientMessageLoop*
 WebSharedWorkerImpl::createClientMessageLoop() {
   return m_client->createDevToolsMessageLoop();
 }
 
 // WorkerReportingProxy --------------------------------------------------------
 
-void WebSharedWorkerImpl::countFeature(UseCounter::Feature) {
-  // TODO(nhiroki): Support UseCounter for SharedWorker. Send an IPC message to
-  // the browser process and ask each connected document to record API use in
-  // its UseCounter (https://crbug.com/376039).
+void WebSharedWorkerImpl::countFeature(UseCounter::Feature feature) {
+  static_assert(UseCounter::NumberOfFeatures < UINT32_MAX,

[dcheng, 2017/02/03 00:40:40]

Another option is just to write this in UseCounter.h

enum Features : uint32_t {
  ...
};

[nhiroki, 2017/02/03 17:28:22]

Good idea! Added it and removed static_asserts.

+                "uint32_t must be larger than number of features");
+  m_parentFrameTaskRunners->get(TaskType::UnspecedTimer)
+      ->postTask(BLINK_FROM_HERE,
+                 crossThreadBind(&WebSharedWorkerClient::countFeature,
+                                 crossThreadUnretained(m_client),
+                                 static_cast<uint32_t>(feature)));
 }
 
-void WebSharedWorkerImpl::countDeprecation(UseCounter::Feature) {
-  // TODO(nhiroki): Support UseCounter for SharedWorker. Send an IPC message to
-  // the browser process and ask each connected document to record API use in
-  // its UseCounter (https://crbug.com/376039).
+void WebSharedWorkerImpl::countDeprecation(UseCounter::Feature feature) {
+  // Go through the same code path with countFeature() because a deprecation
+  // message is already shown on the worker console and a remaining work is just
+  // to record an API use.
+  countFeature(feature);
 }
 
 void WebSharedWorkerImpl::reportException(const String& errorMessage,
                                           std::unique_ptr<SourceLocation>,
                                           int exceptionId) {
   // Not suppported in SharedWorker.
 }
 
 void WebSharedWorkerImpl::reportConsoleMessage(MessageSource,
                                                MessageLevel,
@@ skipping 214 matching lines @@
   if (devtoolsAgent)
     devtoolsAgent->dispatchOnInspectorBackend(sessionId, callId, method,
                                               message);
 }
 
 WebSharedWorker* WebSharedWorker::create(WebSharedWorkerClient* client) {
   return new WebSharedWorkerImpl(client);
 }
 
 }  // namespace blink