Rick Byers
2017/01/26 03:02:37
please use a feature which is Deprecated (or even
please use a feature which is Deprecated (or even one of each). I think you're
going to hit a DCHECK for the deprecated case (since UseCounter.cpp today
doesn't expect deprecated features to come through the normal path). Perhaps we
should just relax that DCHECK if there's not an easy way to separate this case
out...
nhiroki
2017/01/27 16:58:16
You're right! Calling a deprecated feature hits DC
On 2017/01/26 03:02:37, Rick Byers wrote:
> please use a feature which is Deprecated (or even one of each). I think
you're
> going to hit a DCHECK for the deprecated case (since UseCounter.cpp today
> doesn't expect deprecated features to come through the normal path). Perhaps
we
> should just relax that DCHECK if there's not an easy way to separate this case
> out...
You're right! Calling a deprecated feature hits DCHECK. Instead of relaxing the
check, the latest patchset ccheck whether a given feature is deprecated and
calls countDeprecate in the case. See
SharedWorkerRepositoryClientImpl.cpp::countFeature.
Issue 2586863002: Worker: Enable UseCounter for SharedWorkerGlobalScope
(Closed)
Created 4 years ago by nhiroki
Modified 3 years, 10 months ago
Reviewers: Rick Byers, horo, kinuko, dcheng, darin (slow to review)
Base URL:
Comments: 31