Report downloaded resources at most once

components/precache/core/precache_url_table_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/precache/core/precache_url_table.h"
 
 #include <map>
 #include <memory>
 #include <set>
 
+#include "base/bind.h"
+#include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "base/time/time.h"
 #include "sql/connection.h"
 #include "sql/statement.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace precache {
 
 void PrintTo(const PrecacheURLInfo& url_info, ::std::ostream* os) {
   *os << "{" << url_info.was_precached << ", " << url_info.is_precached << ", "
       << url_info.was_used << "}";
 }
 
 namespace {
 
 class PrecacheURLTableTest : public testing::Test {
  public:
   PrecacheURLTableTest() {}
   ~PrecacheURLTableTest() override {}
 
  protected:
   void SetUp() override {
     precache_url_table_.reset(new PrecacheURLTable());
     db_.reset(new sql::Connection());
+    db_->set_error_callback(base::Bind(&PrecacheURLTableTest::SqlErrorCallback,
+                                       base::Unretained(this)));
     ASSERT_TRUE(db_->OpenInMemory());
     ASSERT_TRUE(precache_url_table_->Init(db_.get()));
   }
 
+  void SqlErrorCallback(int line, sql::Statement* statement) {
+    LOG(INFO) << "SQL Error at line " << line << ": "
+              << statement->GetSQLStatement();
+  }
+
   std::unique_ptr<PrecacheURLTable> precache_url_table_;
   std::unique_ptr<sql::Connection> db_;
 };
 
 TEST_F(PrecacheURLTableTest, AddURLWithNoExistingRow) {
   const base::Time kTime = base::Time::FromInternalValue(100);
-  precache_url_table_->AddURL(GURL("http://url.com"), 1, true, kTime);
+  precache_url_table_->AddURL(GURL("http://url.com"), 1, true, true, kTime);
 
   std::map<GURL, base::Time> expected_map;
   expected_map[GURL("http://url.com")] = kTime;
 
   std::map<GURL, base::Time> actual_map;
   precache_url_table_->GetAllDataForTesting(&actual_map);
   EXPECT_EQ(expected_map, actual_map);
 }
 
-TEST_F(PrecacheURLTableTest, AddURLWithExistingRow) {
+TEST_F(PrecacheURLTableTest, AddURLWithExistingRowCached) {
   const base::Time kOldTime = base::Time::FromInternalValue(50);
   const base::Time kNewTime = base::Time::FromInternalValue(100);
-  precache_url_table_->AddURL(GURL("http://url.com"), 1, true, kOldTime);
-  precache_url_table_->AddURL(GURL("http://url.com"), 1, true, kNewTime);
+  precache_url_table_->AddURL(GURL("http://url.com"), 1, true, true, kOldTime);
+  precache_url_table_->AddURL(GURL("http://url.com"), 1, true, true, kNewTime);
 
   std::map<GURL, base::Time> expected_map;
   expected_map[GURL("http://url.com")] = kNewTime;
+
+  std::map<GURL, base::Time> actual_map;
+  precache_url_table_->GetAllDataForTesting(&actual_map);
+  EXPECT_EQ(expected_map, actual_map);
+}
+
+TEST_F(PrecacheURLTableTest, AddURLWithExistingRowNotCached) {
+  const base::Time kOldTime = base::Time::FromInternalValue(50);
+  const base::Time kNewTime = base::Time::FromInternalValue(100);
+  precache_url_table_->AddURL(GURL("http://url.com"), 1, true, false, kOldTime);
+  precache_url_table_->AddURL(GURL("http://url.com"), 1, true, false, kNewTime);
+
+  std::map<GURL, base::Time> expected_map;
+  expected_map[GURL("http://url.com")] = kNewTime;
 
   std::map<GURL, base::Time> actual_map;
   precache_url_table_->GetAllDataForTesting(&actual_map);
   EXPECT_EQ(expected_map, actual_map);
 }
 
 TEST_F(PrecacheURLTableTest, SetURLAsNotPrecached) {
   const base::Time kStaysTime = base::Time::FromInternalValue(50);
   const base::Time kDeletedTime = base::Time::FromInternalValue(100);
 
-  precache_url_table_->AddURL(GURL("http://stays.com"), 1, true, kStaysTime);
-  precache_url_table_->AddURL(GURL("http://deleted.com"), 1, true,
+  precache_url_table_->AddURL(GURL("http://stays.com"), 1, true, true,
+                              kStaysTime);
+  precache_url_table_->AddURL(GURL("http://deleted.com"), 1, true, true,
                               kDeletedTime);
 
   precache_url_table_->SetURLAsNotPrecached(GURL("http://deleted.com"));
 
   std::map<GURL, base::Time> expected_map;
   expected_map[GURL("http://stays.com")] = kStaysTime;
 
   std::map<GURL, base::Time> actual_map;
   precache_url_table_->GetAllDataForTesting(&actual_map);
   EXPECT_EQ(expected_map, actual_map);
 }
 
 TEST_F(PrecacheURLTableTest, GetURLInfo) {
   const GURL url("http://url.com");
 
   EXPECT_EQ((PrecacheURLInfo{false, false, false}),
             precache_url_table_->GetURLInfo(url));
 
-  precache_url_table_->AddURL(url, 1, true, base::Time::FromInternalValue(100));
+  precache_url_table_->AddURL(url, 1, true, true,
+                              base::Time::FromInternalValue(100));
 
   EXPECT_EQ((PrecacheURLInfo{true, true, false}),
             precache_url_table_->GetURLInfo(url));
 
   precache_url_table_->SetPrecachedURLAsUsed(url);
 
   EXPECT_EQ((PrecacheURLInfo{true, false, true}),
             precache_url_table_->GetURLInfo(url));
 
-  precache_url_table_->AddURL(url, 1, true, base::Time::FromInternalValue(100));
+  precache_url_table_->AddURL(url, 1, true, true,
+                              base::Time::FromInternalValue(100));
 
   EXPECT_EQ((PrecacheURLInfo{true, true, false}),
             precache_url_table_->GetURLInfo(url));
 
   precache_url_table_->SetURLAsNotPrecached(url);
 
   EXPECT_EQ((PrecacheURLInfo{true, false, false}),
             precache_url_table_->GetURLInfo(url));
 }
 
 TEST_F(PrecacheURLTableTest, DeleteAllPrecachedBefore) {
   const base::Time kOldTime = base::Time::FromInternalValue(10);
   const base::Time kBeforeTime = base::Time::FromInternalValue(20);
   const base::Time kEndTime = base::Time::FromInternalValue(30);
   const base::Time kAfterTime = base::Time::FromInternalValue(40);
 
-  precache_url_table_->AddURL(GURL("http://old.com"), 1, true, kOldTime);
-  precache_url_table_->AddURL(GURL("http://before.com"), 1, true, kBeforeTime);
-  precache_url_table_->AddURL(GURL("http://end.com"), 1, true, kEndTime);
-  precache_url_table_->AddURL(GURL("http://after.com"), 1, true, kAfterTime);
+  precache_url_table_->AddURL(GURL("http://old.com"), 1, true, true, kOldTime);
+  precache_url_table_->AddURL(GURL("http://before.com"), 1, true, true,
+                              kBeforeTime);
+  precache_url_table_->AddURL(GURL("http://end.com"), 1, true, true, kEndTime);
+  precache_url_table_->AddURL(GURL("http://after.com"), 1, true, true,
+                              kAfterTime);
 
   precache_url_table_->DeleteAllPrecachedBefore(kEndTime);
 
   std::map<GURL, base::Time> expected_map;
   expected_map[GURL("http://end.com")] = kEndTime;
   expected_map[GURL("http://after.com")] = kAfterTime;
 
   std::map<GURL, base::Time> actual_map;
   precache_url_table_->GetAllDataForTesting(&actual_map);
   EXPECT_EQ(expected_map, actual_map);
@@ skipping 35 matching lines @@
     EXPECT_EQ(0, statement.ColumnInt(2));
     EXPECT_EQ(1, statement.ColumnInt(3));
   }
   EXPECT_THAT(std::set<std::string>(begin(old_urls), end(old_urls)),
               ::testing::ContainerEq(actual_urls));
 }
 
 }  // namespace
 
 }  // namespace precache