Report downloaded resources at most once

components/precache/core/precache_url_table.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PRECACHE_CORE_PRECACHE_URL_TABLE_H_
 #define COMPONENTS_PRECACHE_CORE_PRECACHE_URL_TABLE_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/time/time.h"
+#include "sql/statement.h"

[twifkak, 2016/12/20 01:42:00]

If this is for sql::Statement, just fwd declare:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

[jamartin, 2016/12/20 21:09:34]

Done.

 #include "url/gurl.h"
 
 namespace sql {
 class Connection;
 }
 
 namespace precache {
 
 // Information about a given URL with respect to the PrecacheURLTable.
 struct PrecacheURLInfo {
@@ skipping 23 matching lines @@
   PrecacheURLTable();
   ~PrecacheURLTable();
 
   // Initialize the precache URL table for use with the specified database
   // connection. The caller keeps ownership of |db|, and |db| must not be NULL.
   // Init must be called before any other methods.
   bool Init(sql::Connection* db);
 
   // Adds an URL to the table, |referrer_host_id| is the id of the referrer host
   // in PrecacheReferrerHostTable, |is_precached| indicates if the URL is
   // precached, |time| is the timestamp. Replaces the row if one already exists.

[twifkak, 2016/12/20 01:42:00]

Update doc.

[jamartin, 2016/12/20 21:09:34]

Done.

   void AddURL(const GURL& url,
               int64_t referrer_host_id,
               bool is_precached,
+              bool was_cached,
               const base::Time& precache_time);
 
   // Returns information about the URL's status with respect to prefetching.
   PrecacheURLInfo GetURLInfo(const GURL& url);
 
   // Sets the precached URL as used.
   void SetPrecachedURLAsUsed(const GURL& url);
 
   // Set the previously precached URL as not precached, during user browsing.
   void SetURLAsNotPrecached(const GURL& url);
 
   // Populates the used and unused resource URLs for the referrer host with id

[twifkak, 2016/12/20 01:42:00]

s/unused/downloaded

[jamartin, 2016/12/20 21:09:34]

Done.

-  // |referrer_host_id|.
+  // |referrer_host_id|. It will also clear the reported downloaded_urls.
   void GetURLListForReferrerHost(int64_t referrer_host_id,
                                  std::vector<GURL>* used_urls,
-                                 std::vector<GURL>* unused_urls);
+                                 std::vector<GURL>* downloaded_urls);
 
   // Clears all URL entries for the referrer host |referrer_host_id|.
   void ClearAllForReferrerHost(int64_t referrer_host_id);
 
   // Deletes entries that were precached before the time of |delete_end|.
   void DeleteAllPrecachedBefore(const base::Time& delete_end);
 
   // Delete all entries.
   void DeleteAll();
 
   // Used by tests to get the contents of the table.
   void GetAllDataForTesting(std::map<GURL, base::Time>* map);
 
  private:
   bool CreateTableIfNonExistent();
 
+  bool SetIsDownloadReported(int64_t referrer_host_id, const GURL& url);
+
+  bool BindStatementAndRun(const GURL& url,
+                           int64_t referrer_host_id,
+                           bool is_precached,
+                           const base::Time& precache_time,
+                           sql::Statement* statement);
+
   // Non-owned pointer.
   sql::Connection* db_;
 
   DISALLOW_COPY_AND_ASSIGN(PrecacheURLTable);
 };
 
 }  // namespace precache
 
 #endif  // COMPONENTS_PRECACHE_CORE_PRECACHE_URL_TABLE_H_