gpu/ipc/common/gpu_command_buffer_traits_multi.h - Issue 2586803003: Enable creation of offscreen contexts which own their backing surface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gpu/ipc/common/gpu_command_buffer_traits_multi.h

Issue 2586803003: Enable creation of offscreen contexts which own their backing surface. (Closed)

Patch Set: (ownsurface) context priority workaround, update comments, VLOG->DVLOG Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « gpu/command_buffer/service/service_utils.cc ('k') | gpu/ipc/service/gpu_command_buffer_stub.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included message file, hence no include guard here.	5 // Multiply-included message file, hence no include guard here.

6	6

7 #include "gpu/command_buffer/common/capabilities.h"	7 #include "gpu/command_buffer/common/capabilities.h"

8 #include "gpu/command_buffer/common/constants.h"	8 #include "gpu/command_buffer/common/constants.h"

9 #include "gpu/command_buffer/common/gles2_cmd_utils.h"	9 #include "gpu/command_buffer/common/gles2_cmd_utils.h"

10 #include "gpu/gpu_export.h"	10 #include "gpu/gpu_export.h"

(...skipping 127 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
138 IPC_STRUCT_TRAITS_MEMBER(depth_size)	138 IPC_STRUCT_TRAITS_MEMBER(depth_size)

139 IPC_STRUCT_TRAITS_MEMBER(stencil_size)	139 IPC_STRUCT_TRAITS_MEMBER(stencil_size)

140 IPC_STRUCT_TRAITS_MEMBER(samples)	140 IPC_STRUCT_TRAITS_MEMBER(samples)

141 IPC_STRUCT_TRAITS_MEMBER(sample_buffers)	141 IPC_STRUCT_TRAITS_MEMBER(sample_buffers)

142 IPC_STRUCT_TRAITS_MEMBER(buffer_preserved)	142 IPC_STRUCT_TRAITS_MEMBER(buffer_preserved)

143 IPC_STRUCT_TRAITS_MEMBER(bind_generates_resource)	143 IPC_STRUCT_TRAITS_MEMBER(bind_generates_resource)

144 IPC_STRUCT_TRAITS_MEMBER(fail_if_major_perf_caveat)	144 IPC_STRUCT_TRAITS_MEMBER(fail_if_major_perf_caveat)

145 IPC_STRUCT_TRAITS_MEMBER(lose_context_when_out_of_memory)	145 IPC_STRUCT_TRAITS_MEMBER(lose_context_when_out_of_memory)

146 IPC_STRUCT_TRAITS_MEMBER(context_type)	146 IPC_STRUCT_TRAITS_MEMBER(context_type)

147 IPC_STRUCT_TRAITS_MEMBER(should_use_native_gmb_for_backbuffer)	147 IPC_STRUCT_TRAITS_MEMBER(should_use_native_gmb_for_backbuffer)

	148 IPC_STRUCT_TRAITS_MEMBER(own_offscreen_surface)
	bajones 2017/01/06 23:14:04 Don't we need to add `low_priority` here? Don't we need to add `low_priority` here? klausw 2017/01/07 00:02:34 I've added it for consistency. In practice I don't Show quoted text On 2017/01/06 23:14:04, bajones wrote: > Don't we need to add `low_priority` here? I've added it for consistency. In practice I don't think it matters, looks like the attributes from the helper get used in two different paths. Some (including low_priority) are forked into gl::GLContextAttributes by service_utils's GenerateGLContextAttribs, others are passed down to gpu_command_buffer_stub as init_params.attribs, but in this case this doesn't look at the low_priority attribute.
148 IPC_STRUCT_TRAITS_END()	149 IPC_STRUCT_TRAITS_END()

OLD	NEW