ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html - Issue 2586803002: MD Settings: Fix label visibility in subpage search fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Issue 2586803002: MD Settings: Fix label visibility in subpage search fields (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js ('k') | ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

diff --git a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

index 79020dda252b438d8ca2dc2e4955f785caa5a5d1..c274e197e1c481a08800fbd6babfb6880411a0d0 100644

--- a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

+++ b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

@@ -75,7 +75,7 @@

white-space: nowrap;

}

- :host([has-search-text_]) label {

+ :host([has-search-text]) label {

visibility: hidden;

}

@@ -140,7 +140,7 @@

<label id="prompt" for="searchInput">[[label]]</label>

<input id="searchInput"

type="search"

- on-input="onSearchInput_"

+ on-input="onSearchTermInput"

on-search="onSearchTermSearch"

on-keydown="onSearchTermKeydown_"

on-focus="onInputFocus_"

@@ -149,7 +149,7 @@

autofocus>

</input>

</div>

- <template is="dom-if" if="[[hasSearchText_]]">

+ <template is="dom-if" if="[[hasSearchText]]">

<paper-icon-button icon="cr:cancel" id="clearSearch"

title="[[clearLabel]]" on-tap="clearSearch_">

</paper-icon-button>