chrome/browser/resources/settings/settings_page/settings_subpage_search.html - Issue 2586803002: MD Settings: Fix label visibility in subpage search fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage_search.html

Issue 2586803002: MD Settings: Fix label visibility in subpage search fields (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/md_history/app.vulcanized.html ('k') | chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_subpage_search.html

diff --git a/chrome/browser/resources/settings/settings_page/settings_subpage_search.html b/chrome/browser/resources/settings/settings_page/settings_subpage_search.html

index fceecab568b8adf6811e81ce49ffc469c7f21cc5..be683d57e7230c3406eb4fc29707bc90c0b17382 100644

--- a/chrome/browser/resources/settings/settings_page/settings_subpage_search.html

+++ b/chrome/browser/resources/settings/settings_page/settings_subpage_search.html

@@ -3,7 +3,6 @@

-<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">

<dom-module id="settings-subpage-search">

@@ -52,6 +51,10 @@

color: var(--paper-grey-600);

}

+ :host([has-search-text]) #prompt {

+ visibility: hidden;

+ }

#searchInput {

color: var(--paper-grey-800);

}

@@ -62,13 +65,14 @@

}

</style>

<paper-icon-button id="searchIcon" icon="cr:search"></paper-icon-button>

- <paper-input-container no-label-float on-search="onSearchTermSearch">

+ <paper-input-container no-label-float>

<label id="prompt">[[label]]</label>

- <input is="iron-input" id="searchInput" type="search"

- aria-labelledby="prompt" incremental>

+ <input id="searchInput" type="search" on-search="onSearchTermSearch"

+ on-input="onSearchTermInput" aria-labelledby="prompt" incremental>

</input>

<paper-icon-button suffix icon="cr:cancel" id="clearSearch"

- on-tap="onTapClear_" title="[[clearLabel]]" hidden$="[[!lastValue_]]">

+ on-tap="onTapClear_" title="[[clearLabel]]"

+ hidden$="[[!hasSearchText]]">

</paper-icon-button>

</paper-input-container>

</template>