Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 25868004: net: don't send resumption ClientHello records with versions > 0x0301. (Closed)

Created:
5 years, 7 months ago by agl
Modified:
5 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi
Visibility:
Public.

Description

net: don't send resumption ClientHello records with versions > 0x0301. Best we can tell, F5 BIG-IP devices with firmware < 10.2.4 hang the connection when a ClientHello record is received with version > 0x0301 and is longer than 255 bytes. With TLS 1.2, we're hitting this size limit on resume connections with long hostnames. Since the servers negotiate TLS 1.2, NSS previously used 0x0303 as the ClientHello record version. This change causes NSS to always use at most 0x0301 as the ClientHello record version, even when we are resuming a session and know that the server supports TLS 1.2. See http://rt.openssl.org/Ticket/Display.html?id=2771#txn-33812 https://bugzilla.mozilla.org/show_bug.cgi?id=923696 BUG=303398 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227331

Patch Set 1 #

Patch Set 2 : Add reference to Bugzilla bug. #

Total comments: 2

Patch Set 3 : Update comment. #

Patch Set 4 : Update patch file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M net/third_party/nss/README.chromium View 1 1 chunk +6 lines, -0 lines 0 comments Download
A net/third_party/nss/patches/resumeclienthelloversion.patch View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
agl
5 years, 7 months ago (2013-10-04 17:50:53 UTC) #1
wtc
Patch set 2 LGTM. We should update our description of the ssl_SEND_FLAG_CAP_RECORD_VERSION to reflect our ...
5 years, 7 months ago (2013-10-07 17:55:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/25868004/12001
5 years, 7 months ago (2013-10-07 18:14:37 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2013-10-07 20:19:30 UTC) #4
Message was sent while issue was closed.
Change committed as 227331

Powered by Google App Engine
This is Rietveld 408576698