Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 2586743002: correct path to build instructions (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 class WinPort(base.Port): 49 class WinPort(base.Port):
50 port_name = 'win' 50 port_name = 'win'
51 51
52 SUPPORTED_VERSIONS = ('win7', 'win10') 52 SUPPORTED_VERSIONS = ('win7', 'win10')
53 53
54 FALLBACK_PATHS = {'win10': ['win']} 54 FALLBACK_PATHS = {'win10': ['win']}
55 FALLBACK_PATHS['win7'] = ['win7'] + FALLBACK_PATHS['win10'] 55 FALLBACK_PATHS['win7'] = ['win7'] + FALLBACK_PATHS['win10']
56 56
57 DEFAULT_BUILD_DIRECTORIES = ('build', 'out') 57 DEFAULT_BUILD_DIRECTORIES = ('build', 'out')
58 58
59 BUILD_REQUIREMENTS_URL = 'http://www.chromium.org/developers/how-tos/build-i nstructions-windows' 59 BUILD_REQUIREMENTS_URL = 'https://chromium.googlesource.com/chromium/src/+/m aster/docs/windows_build_instructions.md'
60 60
61 @classmethod 61 @classmethod
62 def determine_full_port_name(cls, host, options, port_name): 62 def determine_full_port_name(cls, host, options, port_name):
63 if port_name.endswith('win'): 63 if port_name.endswith('win'):
64 assert host.platform.is_win() 64 assert host.platform.is_win()
65 # We don't maintain separate baselines for vista, so we pretend it i s win7. 65 # We don't maintain separate baselines for vista, so we pretend it i s win7.
66 if host.platform.os_version in ('vista', '7sp0', '7sp1'): 66 if host.platform.os_version in ('vista', '7sp0', '7sp1'):
67 version = 'win7' 67 version = 'win7'
68 # Same for win8, we treat it as win10. 68 # Same for win8, we treat it as win10.
69 elif host.platform.os_version in ('8', '8.1', '10', 'future'): 69 elif host.platform.os_version in ('8', '8.1', '10', 'future'):
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 def check_build(self, needs_http, printer): 181 def check_build(self, needs_http, printer):
182 result = super(WinPort, self).check_build(needs_http, printer) 182 result = super(WinPort, self).check_build(needs_http, printer)
183 183
184 self._crash_service_available = self._check_crash_service_available() 184 self._crash_service_available = self._check_crash_service_available()
185 if not self._crash_service_available: 185 if not self._crash_service_available:
186 result = test_run_results.UNEXPECTED_ERROR_EXIT_STATUS 186 result = test_run_results.UNEXPECTED_ERROR_EXIT_STATUS
187 187
188 if result: 188 if result:
189 _log.error('For complete Windows build requirements, please see:') 189 _log.error('For complete Windows build requirements, please see:')
190 _log.error('') 190 _log.error('')
191 _log.error(' http://dev.chromium.org/developers/how-tos/build-ins tructions-windows') 191 _log.error(' https://chromium.googlesource.com/chromium/src/+/mas ter/docs/windows_build_instructions.md')
192 return result 192 return result
193 193
194 def operating_system(self): 194 def operating_system(self):
195 return 'win' 195 return 'win'
196 196
197 def relative_test_filename(self, filename): 197 def relative_test_filename(self, filename):
198 path = filename[len(self.layout_tests_dir()) + 1:] 198 path = filename[len(self.layout_tests_dir()) + 1:]
199 return path.replace('\\', '/') 199 return path.replace('\\', '/')
200 200
201 def uses_apache(self): 201 def uses_apache(self):
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 return result 242 return result
243 243
244 def look_for_new_crash_logs(self, crashed_processes, start_time): 244 def look_for_new_crash_logs(self, crashed_processes, start_time):
245 if self.get_option('disable_breakpad'): 245 if self.get_option('disable_breakpad'):
246 return None 246 return None
247 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time) 247 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time)
248 248
249 def clobber_old_port_specific_results(self): 249 def clobber_old_port_specific_results(self):
250 if not self.get_option('disable_breakpad'): 250 if not self.get_option('disable_breakpad'):
251 self._dump_reader.clobber_old_results() 251 self._dump_reader.clobber_old_results()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698