Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

Issue 2586633002: Dispose a persisted plugin widget if the content frame is detached. (Closed)
Patch Set: Fix typos Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
index 21bda51956d9b8256056dc69e00967801df29948..b88a672e16ba1d65cfa2d9ce7bcbf30d45102f9a 100644
--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
@@ -67,8 +67,6 @@ class CORE_EXPORT HTMLPlugInElement : public HTMLFrameOwnerElement {
void requestPluginCreationWithoutLayoutObjectIfPossible();
void createPluginWithoutLayoutObject();
- void removedFrom(ContainerNode* insertionPoint) override;
-
protected:
HTMLPlugInElement(const QualifiedName& tagName,
Document&,
@@ -76,6 +74,7 @@ class CORE_EXPORT HTMLPlugInElement : public HTMLFrameOwnerElement {
PreferPlugInsForImagesOption);
// Node functions:
+ void removedFrom(ContainerNode* insertionPoint) override;
void didMoveToNewDocument(Document& oldDocument) override;
// Element functions:
@@ -115,10 +114,10 @@ class CORE_EXPORT HTMLPlugInElement : public HTMLFrameOwnerElement {
bool m_isDelayingLoadEvent;
private:
- // EventTarget functions:
+ // EventTarget overrides:
void removeAllEventListeners() final;
- // Node functions:
+ // Node overrides:
bool canContainRangeEndPoint() const override { return false; }
bool canStartSelection() const override;
bool willRespondToMouseClickEvents() final;
@@ -127,17 +126,20 @@ class CORE_EXPORT HTMLPlugInElement : public HTMLFrameOwnerElement {
void detachLayoutTree(const AttachContext& = AttachContext()) final;
void finishParsingChildren() final;
- // Element functions:
+ // Element overrides:
LayoutObject* createLayoutObject(const ComputedStyle&) override;
bool supportsFocus() const final { return true; }
bool layoutObjectIsFocusable() const final;
bool isKeyboardFocusable() const final;
void didAddUserAgentShadowRoot(ShadowRoot&) final;
- // HTMLElement function:
+ // HTMLElement overrides:
bool hasCustomFocusLogic() const override;
bool isPluginElement() const final;
+ // HTMLFrameOwnerElement overrides:
+ void disconnectContentFrame() override;
+
// Return any existing LayoutPart without triggering relayout, or 0 if it
// doesn't yet exist.
virtual LayoutPart* existingLayoutPart() const = 0;

Powered by Google App Engine
This is Rietveld 408576698