Use texture-backed VideoFrame pipeline for Aura desktop capturing.

content/renderer/media/webrtc/media_stream_remote_video_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/webrtc/media_stream_remote_video_source.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "content/renderer/media/native_handle_impl.h"
@@ skipping 46 matching lines @@
 void MediaStreamRemoteVideoSource::SetSize(int width, int height) {
 }
 
 void MediaStreamRemoteVideoSource::RenderFrame(
     const cricket::VideoFrame* frame) {
   base::TimeDelta timestamp = base::TimeDelta::FromMilliseconds(
       frame->GetTimeStamp() / talk_base::kNumNanosecsPerMillisec);
 
   scoped_refptr<media::VideoFrame> video_frame;
   if (frame->GetNativeHandle() != NULL) {
-    NativeHandleImpl* handle =
-        static_cast<NativeHandleImpl*>(frame->GetNativeHandle());
-    video_frame = static_cast<media::VideoFrame*>(handle->GetHandle());
+    video_frame = static_cast<media::VideoFrame*>(frame->GetNativeHandle());

[Ami GONE FROM CHROMIUM, 2014/04/30 03:03:43]

urr, wat?

What happened in this thunk?

[hshi1, 2014/04/30 18:05:19]

I actually don't think this change is correct, we should revert this file.

The cricket::VideoFrame::GetNativeHandle() returns a valid (void*) handle if the
VideoFrame object is an instance of class cricket::WebRtcTextureVideoFrame.
Aside from a trivial copy constructor, the only path I found to construct such
an instance is via call WebRtcVideoEngine::DeliverFrame() ->
WebRtcVideoEngine::DeliverTextureFrame().

Example of call to DeliverFrame() with valid handle: vie_renderer.cc:
ViEExternalRendererImpl::RenderFrame() where the handle comes from
webrtc::TextureVideoFrame::native_handle().

Example of constructor of webrtc::TextureVideoFrame is seen in
RTCVideoDecoder::PictureReady() where we supply the handle as new
webrtc::RefCountImpl<NativeHandleImpl>(media::VideoFrame).

Thus, the frame->GetNativeHandle() should be first static_cast'ed to
NativeHandleImpl* and then we obtain media::VideoFrame* pointer with
NativeHandleImpl::GetHandle(), as originally written.

     video_frame->set_timestamp(timestamp);
   } else {
     gfx::Size size(frame->GetWidth(), frame->GetHeight());
     video_frame = frame_pool_.CreateFrame(
         media::VideoFrame::YV12, size, gfx::Rect(size), size, timestamp);
 
     // Non-square pixels are unsupported.
     DCHECK_EQ(frame->GetPixelWidth(), 1u);
     DCHECK_EQ(frame->GetPixelHeight(), 1u);
 
@@ skipping 66 matching lines @@
 }
 
 void MediaStreamRemoteVideoSource::DoRenderFrameOnMainThread(
     scoped_refptr<media::VideoFrame> video_frame) {
   DCHECK(message_loop_proxy_->BelongsToCurrentThread());
   if (state() == STARTED)
     DeliverVideoFrame(video_frame);
 }
 
 }  // namespace content