Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2480)

Unified Diff: base/android/sys_utils.cc

Issue 258663002: Expose a low-end device mode override flags for non-android OSs as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaseline again Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/sys_utils.cc
diff --git a/base/android/sys_utils.cc b/base/android/sys_utils.cc
index efd13df3d42e814772987f93c66e81094294e0ad..4cbaf787072edeca9a8115f6a7bf40297b6bb326 100644
--- a/base/android/sys_utils.cc
+++ b/base/android/sys_utils.cc
@@ -5,37 +5,32 @@
#include "base/android/sys_utils.h"
#include "base/android/build_info.h"
+#include "base/lazy_instance.h"
#include "base/sys_info.h"
+#include "base/sys_info_internal.h"
#include "jni/SysUtils_jni.h"
namespace base {
namespace android {
-bool SysUtils::Register(JNIEnv* env) {
+bool SysUtilsAndroid::Register(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-bool SysUtils::IsLowEndDeviceFromJni() {
+bool SysUtilsAndroid::IsLowEndDeviceFromJni() {
JNIEnv* env = AttachCurrentThread();
return Java_SysUtils_isLowEndDevice(env);
}
-bool SysUtils::IsLowEndDevice() {
- static bool is_low_end = IsLowEndDeviceFromJni();
- return is_low_end;
-}
+} // namespace android
-size_t SysUtils::AmountOfPhysicalMemoryKBFromJni() {
- JNIEnv* env = AttachCurrentThread();
- return static_cast<size_t>(Java_SysUtils_amountOfPhysicalMemoryKB(env));
-}
+static base::LazyInstance<
+ base::internal::LazySysInfoValue<bool,
+ android::SysUtilsAndroid::IsLowEndDeviceFromJni> >::Leaky
+ g_lazy_low_end_device = LAZY_INSTANCE_INITIALIZER;
-size_t SysUtils::AmountOfPhysicalMemoryKB() {
- static size_t amount_of_ram = AmountOfPhysicalMemoryKBFromJni();
- return amount_of_ram;
+bool SysInfo::IsLowEndDevice() {
Yaron 2014/06/23 18:48:00 I think this should move to base/sys_info_android.
c.shu 2014/06/23 18:56:40 sounds good.
+ return g_lazy_low_end_device.Get().value();
}
-SysUtils::SysUtils() { }
-
-} // namespace android
-} // namespace base
+} // namespace base

Powered by Google App Engine
This is Rietveld 408576698