Expose a low-end device mode override flags for non-android OSs as well

base/base_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_switches.h"
 
 namespace switches {
 
 // Disables the crash reporting.
 const char kDisableBreakpad[]               = "disable-breakpad";
 
+// Overrides low-end device detection, disabling low-end device optimizations.
+const char kDisableLowEndDeviceMode[]       = "disable-low-end-device-mode";
+
 // Indicates that crash reporting should be enabled. On platforms where helper
 // processes cannot access to files needed to make this decision, this flag is
 // generated internally.
 const char kEnableCrashReporter[]           = "enable-crash-reporter";
 
+// Overrides low-end device detection, enabling low-end device optimizations.
+const char kEnableLowEndDeviceMode[] = "enable-low-end-device-mode";

[brettw, 2014/06/11 21:02:40]

Can you align the = on this one and the next one you added for consistency?
(unless it makes it >80 cols)

[c.shu, 2014/06/12 21:12:48]

Done.

+
 // Generates full memory crash dump.
 const char kFullMemoryCrashReport[]         = "full-memory-crash-report";
 
 // Suppresses all error dialogs when present.
 const char kNoErrorDialogs[]                = "noerrdialogs";
 
 // When running certain tests that spawn child processes, this switch indicates
 // to the test framework that the current process is a child process.
 const char kTestChildProcess[]              = "test-child-process";
 
@@ skipping 26 matching lines @@
 // chrome://profiler.
 const char kProfilerTimingDisabledValue[]   = "0";
 
 #if defined(OS_POSIX)
 // Used for turning on Breakpad crash reporting in a debug environment where
 // crash reporting is typically compiled but disabled.
 const char kEnableCrashReporterForTesting[] =
     "enable-crash-reporter-for-testing";
 #endif
 
-#if defined(OS_ANDROID)
-// Overrides low-end device detection, disabling low-end device optimizations.
-const char kDisableLowEndDeviceMode[]       = "disable-low-end-device-mode";
-
-// Overrides low-end device detection, enabling low-end device optimizations.
-const char kEnableLowEndDeviceMode[]        = "enable-low-end-device-mode";
+#if !defined(OS_ANDROID)
+// Indicates whether to detect low-end device.
+const char kDetectLowEndDevice[] = "detect-low-end-device";

[brettw, 2014/06/11 21:02:40]

I'm not super excited about having 3 arguments to control this. Is it possible
to do something like:
--low-end-device-mode=0  meaning not low end
--low-end-device-mode=1  meaning low end
with undefined/empty meaning autodetect.

[c.shu, 2014/06/12 21:18:11]

I agree, brettw. I have a concern though the
enable-low-end-device/disable-low-end-device are already used on Android. Would
it cause some problem for some scripts if we changed the behavior?

 #endif
 
 }  // namespace switches