remoting/protocol/session_plugin.cc - Issue 2586403003: [Chromoting] Add SessionPlugin in JingleSession

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/protocol/session_plugin.cc

Issue 2586403003: [Chromoting] Add SessionPlugin in JingleSession (Closed)

Patch Set: Resolve review comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "remoting/base/constants.h"

	6 #include "remoting/protocol/session_plugin.h"

	7

	8 namespace remoting {

	9 namespace protocol {

	10

	11 SessionPlugin::SessionPlugin() = default;

	12

	13 SessionPlugin::~SessionPlugin() = default;
	Sergey Ulanov 2016/12/23 00:14:52 constructor/destructor for interfaces can be inlin constructor/destructor for interfaces can be inlined in the header. Then you wouldn't need this file. Hzj_jie 2016/12/24 00:09:55 Done. Show quoted text On 2016/12/23 00:14:52, Sergey Ulanov wrote: > constructor/destructor for interfaces can be inlined in the header. Then you > wouldn't need this file. Done.
	14

	15 } // namespace protocol

	16 } // namespace remoting

OLD	NEW