Support + concatenation in constant expressions with strings

Support + concatenation in constant expressions with strings

BUG=
R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/be6a822daff2fae75a480d7da656ab0d9c86512e

[mfairhurst, 2016-12-20 01:09:46]

Description was changed from

==========
Support + concatenation in constant expressions with strings

BUG=
==========

to

==========
Support + concatenation in constant expressions with strings

BUG=
==========

[mfairhurst, 2016-12-20 01:09:46]

mfairhurst@google.com changed reviewers:
+ brianwilkerson@google.com

[mfairhurst, 2016-12-20 01:10:47]

Using this in the analyzer to handle constant expressions where we used to be
expecting string literals.

[mfairhurst, 2016-12-22 22:25:06]

Description was changed from

==========
Support + concatenation in constant expressions with strings

BUG=
==========

to

==========
Support + concatenation in constant expressions with strings

Adding more reviewers since everyone is out.
BUG=
==========

[mfairhurst, 2016-12-22 22:25:06]

mfairhurst@google.com changed reviewers:
+ jmesserly@google.com, paulberry@google.com, scheglov@google.com

[mfairhurst, 2016-12-22 22:25:23]

Description was changed from

==========
Support + concatenation in constant expressions with strings

Adding more reviewers since everyone is out.
BUG=
==========

to

==========
Support + concatenation in constant expressions with strings

BUG=
==========

[mfairhurst, 2016-12-22 22:25:39]

Adding more reviewers since everyone's out

[scheglov, 2016-12-22 23:22:55]

lgtm

https://codereview.chromium.org/2586363004/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/ast/utilities_test.dart (right):

https://codereview.chromium.org/2586363004/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/ast/utilities_test.dart:214: void
test_binary_plus_string_mixed() {
Maybe worth to test when both case for num/string combination:
test_binary_plus_int_string and test_binary_plus_string_int?
And maybe also double?

[mfairhurst, 2016-12-23 00:04:42]

https://codereview.chromium.org/2586363004/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/ast/utilities_test.dart (right):

https://codereview.chromium.org/2586363004/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/ast/utilities_test.dart:214: void
test_binary_plus_string_mixed() {
On 2016/12/22 23:22:54, scheglov wrote:
> Maybe worth to test when both case for num/string combination:
> test_binary_plus_int_string and test_binary_plus_string_int?
> And maybe also double?

Acknowledged.

[Paul Berry, 2016-12-23 15:46:39]

lgtm

[mfairhurst, 2016-12-23 19:26:25]

Description was changed from

==========
Support + concatenation in constant expressions with strings

BUG=
==========

to

==========
Support + concatenation in constant expressions with strings

BUG=
R=paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/be6a822daff2fae75a480d7da656ab0d9c86512e
==========

[mfairhurst, 2016-12-23 19:26:26]

Committed patchset #2 (id:20001) manually as
be6a822daff2fae75a480d7da656ab0d9c86512e (presubmit successful).