Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: appengine/findit/crash/test/crash_test_suite.py

Issue 2586343002: renamed the "Suspects" class to "SuspectMap", to reduce confusion. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/crash/suspect.py ('k') | appengine/findit/crash/test/suspect_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from testing_utils import testing 5 from testing_utils import testing
6 from crash.test.stacktrace_test_suite import StacktraceTestSuite 6 from crash.test.stacktrace_test_suite import StacktraceTestSuite
7 7
8 8
9 class CrashTestSuite(StacktraceTestSuite): # pragma: no cover. 9 class CrashTestSuite(StacktraceTestSuite): # pragma: no cover.
10 10
(...skipping 25 matching lines...) Expand all
36 36
37 self.assertEqual(suspect1.file_to_stack_infos.keys(), 37 self.assertEqual(suspect1.file_to_stack_infos.keys(),
38 suspect2.file_to_stack_infos.keys()) 38 suspect2.file_to_stack_infos.keys())
39 for file_path in suspect1.file_to_stack_infos.keys(): 39 for file_path in suspect1.file_to_stack_infos.keys():
40 self._VerifyTwoStackInfosEqual(suspect1.file_to_stack_infos[file_path], 40 self._VerifyTwoStackInfosEqual(suspect1.file_to_stack_infos[file_path],
41 suspect2.file_to_stack_infos[file_path]) 41 suspect2.file_to_stack_infos[file_path])
42 42
43 self.assertEqual(suspect1.file_to_analysis_info, 43 self.assertEqual(suspect1.file_to_analysis_info,
44 suspect2.file_to_analysis_info) 44 suspect2.file_to_analysis_info)
45 45
46 def _VerifyTwoSuspectsEqual(self, suspects1, suspects2): 46 def _VerifyTwoSuspectMapEqual(self, suspects1, suspects2):
47 """Assert that two ``Suspects`` objects are equal.""" 47 """Assert that two ``SuspectMap`` objects are equal."""
48 self.assertEqual(suspects1._ignore_cls, suspects2._ignore_cls) 48 self.assertEqual(suspects1._ignore_cls, suspects2._ignore_cls)
49 49
50 self.assertEqual(len(suspects1), len(suspects2)) 50 self.assertEqual(len(suspects1), len(suspects2))
51 for revision1, suspect1 in suspects1.iteritems(): 51 for revision1, suspect1 in suspects1.iteritems():
52 self.assertTrue(revision1 in suspects2) 52 self.assertTrue(revision1 in suspects2)
53 self._VerifyTwoSuspectEqual(suspect1, suspects2[revision1]) 53 self._VerifyTwoSuspectEqual(suspect1, suspects2[revision1])
OLDNEW
« no previous file with comments | « appengine/findit/crash/suspect.py ('k') | appengine/findit/crash/test/suspect_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698