Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: ui/base/accelerators/accelerator_manager.cc

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Add unimplemented methods Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/accelerators/accelerator_manager.cc
diff --git a/ui/base/accelerators/accelerator_manager.cc b/ui/base/accelerators/accelerator_manager.cc
index fad3bf66eebfd288ced3eb05e517c03de3b53e89..5f11edbb26a452f83e28faafd6e75b3a97c52f4a 100644
--- a/ui/base/accelerators/accelerator_manager.cc
+++ b/ui/base/accelerators/accelerator_manager.cc
@@ -24,7 +24,7 @@ void AcceleratorManager::Register(const Accelerator& accelerator,
AcceleratorTargetList& targets = accelerators_[accelerator].second;
DCHECK(std::find(targets.begin(), targets.end(), target) == targets.end())
<< "Registering the same target multiple times";
- const bool is_first_target_for_accelerator = targets.empty();
+ // const bool is_first_target_for_accelerator = targets.empty();
// All priority accelerators go to the front of the line.
if (priority == kHighPriority) {
@@ -42,8 +42,11 @@ void AcceleratorManager::Register(const Accelerator& accelerator,
else
targets.insert(++targets.begin(), target);
}
- if (is_first_target_for_accelerator && delegate_)
- delegate_->OnAcceleratorRegistered(accelerator);
+}
+
+void AcceleratorManager::Registers(std::vector<ui::Accelerator>& accelerators) {
+ if (delegate_)
+ delegate_->OnAcceleratorsRegistered(accelerators);
}
void AcceleratorManager::Unregister(const Accelerator& accelerator,

Powered by Google App Engine
This is Rietveld 408576698