Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2259)

Unified Diff: ui/base/accelerators/accelerator_manager_delegate.h

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: fix nits/format and refactor AcceleratorControllerTest.Register. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/accelerators/accelerator_manager_delegate.h
diff --git a/ui/base/accelerators/accelerator_manager_delegate.h b/ui/base/accelerators/accelerator_manager_delegate.h
index e3c6d9ccf6e53ebee773c721a1374ae0b03e18c0..b780dcf6604eeed4f56b6a9bc6e2c70ae0796f4c 100644
--- a/ui/base/accelerators/accelerator_manager_delegate.h
+++ b/ui/base/accelerators/accelerator_manager_delegate.h
@@ -13,11 +13,12 @@ class Accelerator;
class UI_BASE_EXPORT AcceleratorManagerDelegate {
public:
- // Called the first time a target is registered for |accelerator|. This is
- // only called the first time a target is registered for a unique accelerator.
- // For example, if Register() is called twice with the same accelerator
- // this is called only for the first call.
- virtual void OnAcceleratorRegistered(const Accelerator& accelerator) = 0;
+ // Called when a number of accelerators are registered at once. An accelerator
sky 2017/01/28 00:09:15 How about: Called when new accelerators are regist
thanhph1 2017/01/30 16:37:54 Done, thanks! This is clear.
+ // is only included in the |accelerators| vector when the first time a target
+ // for the accelerator is registered. For example, if Register() is called
+ // twice with the same accelerator, this is called only for the first call.
+ virtual void OnAcceleratorsRegistered(
+ const std::vector<ui::Accelerator>& accelerators) = 0;
// Called when there no more targets are registered for |accelerator|.
virtual void OnAcceleratorUnregistered(const Accelerator& accelerator) = 0;

Powered by Google App Engine
This is Rietveld 408576698