Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: ui/base/accelerators/accelerator_manager_delegate.h

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Remove OnAcceleratorRegistered. Update comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/accelerators/accelerator_manager_delegate.h
diff --git a/ui/base/accelerators/accelerator_manager_delegate.h b/ui/base/accelerators/accelerator_manager_delegate.h
index e3c6d9ccf6e53ebee773c721a1374ae0b03e18c0..99370896dca0fa4a1cce17b03bced0abeb0da6e6 100644
--- a/ui/base/accelerators/accelerator_manager_delegate.h
+++ b/ui/base/accelerators/accelerator_manager_delegate.h
@@ -13,15 +13,16 @@ class Accelerator;
class UI_BASE_EXPORT AcceleratorManagerDelegate {
public:
- // Called the first time a target is registered for |accelerator|. This is
- // only called the first time a target is registered for a unique accelerator.
- // For example, if Register() is called twice with the same accelerator
- // this is called only for the first call.
- virtual void OnAcceleratorRegistered(const Accelerator& accelerator) = 0;
-
// Called when there no more targets are registered for |accelerator|.
virtual void OnAcceleratorUnregistered(const Accelerator& accelerator) = 0;
+ // Called when a number of accelerators are registered at once. An accelerator
+ // is only included in the |accelerators| vector when the first time a target
+ // for the accelerator is registered. For example, if Register() is called
+ // twice with the same accelerator, this is called only for the first call.
+ virtual void OnAcceleratorVectorRegistered(
mfomitchev 2017/01/26 21:39:49 Sorry for back-and-forth on this, but now that we
thanhph1 2017/01/26 22:24:05 Done, ya this name is shorter.
+ const std::vector<ui::Accelerator>& accelerators) = 0;
+
protected:
virtual ~AcceleratorManagerDelegate() {}
};

Powered by Google App Engine
This is Rietveld 408576698