| Index: ui/base/accelerators/accelerator_manager_unittest.cc
|
| diff --git a/ui/base/accelerators/accelerator_manager_unittest.cc b/ui/base/accelerators/accelerator_manager_unittest.cc
|
| index 5383403be6799c3ebcd0900b668ef3a47f622eea..b2f8463440f4a8f7fa6cb76f4389580d11fffce5 100644
|
| --- a/ui/base/accelerators/accelerator_manager_unittest.cc
|
| +++ b/ui/base/accelerators/accelerator_manager_unittest.cc
|
| @@ -96,12 +96,19 @@ class TestAcceleratorManagerDelegate : public AcceleratorManagerDelegate {
|
| commands_ += " ";
|
| commands_ += "Register " + accelerator_to_id_[accelerator];
|
| }
|
| +
|
| void OnAcceleratorUnregistered(const Accelerator& accelerator) override {
|
| if (!commands_.empty())
|
| commands_ += " ";
|
| commands_ += "Unregister " + accelerator_to_id_[accelerator];
|
| }
|
|
|
| + void OnAcceleratorVectorRegistered(
|
| + const std::vector<ui::Accelerator>& accelerators) override {
|
| + for (auto iter = accelerators.begin(); iter != accelerators.end(); ++iter)
|
| + OnAcceleratorRegistered(*iter);
|
| + }
|
| +
|
| private:
|
| std::map<Accelerator, std::string> accelerator_to_id_;
|
| std::string commands_;
|
| @@ -125,7 +132,7 @@ TEST_F(AcceleratorManagerTest, Register) {
|
| const Accelerator accelerator_a(VKEY_A, EF_NONE);
|
| TestTarget target;
|
| delegate_.SetIdForAccelerator(accelerator_a, "a");
|
| - manager_.Register(accelerator_a, AcceleratorManager::kNormalPriority,
|
| + manager_.Register({accelerator_a}, AcceleratorManager::kNormalPriority,
|
| &target);
|
| EXPECT_EQ("Register a", delegate_.GetAndClearCommands());
|
|
|
| @@ -138,11 +145,11 @@ TEST_F(AcceleratorManagerTest, RegisterMultipleTarget) {
|
| const Accelerator accelerator_a(VKEY_A, EF_NONE);
|
| delegate_.SetIdForAccelerator(accelerator_a, "a");
|
| TestTarget target1;
|
| - manager_.Register(accelerator_a, AcceleratorManager::kNormalPriority,
|
| + manager_.Register({accelerator_a}, AcceleratorManager::kNormalPriority,
|
| &target1);
|
| EXPECT_EQ("Register a", delegate_.GetAndClearCommands());
|
| TestTarget target2;
|
| - manager_.Register(accelerator_a, AcceleratorManager::kNormalPriority,
|
| + manager_.Register({accelerator_a}, AcceleratorManager::kNormalPriority,
|
| &target2);
|
| // Registering the same command shouldn't notify the delegate.
|
| EXPECT_TRUE(delegate_.GetAndClearCommands().empty());
|
| @@ -158,14 +165,14 @@ TEST_F(AcceleratorManagerTest, Unregister) {
|
| const Accelerator accelerator_a(VKEY_A, EF_NONE);
|
| delegate_.SetIdForAccelerator(accelerator_a, "a");
|
| TestTarget target;
|
| - manager_.Register(accelerator_a, AcceleratorManager::kNormalPriority,
|
| - &target);
|
| - EXPECT_EQ("Register a", delegate_.GetAndClearCommands());
|
| +
|
| const Accelerator accelerator_b(VKEY_B, EF_NONE);
|
| delegate_.SetIdForAccelerator(accelerator_b, "b");
|
| - manager_.Register(accelerator_b, AcceleratorManager::kNormalPriority,
|
| - &target);
|
| - EXPECT_EQ("Register b", delegate_.GetAndClearCommands());
|
| +
|
| + manager_.Register({accelerator_a, accelerator_b},
|
| + AcceleratorManager::kNormalPriority, &target);
|
| +
|
| + EXPECT_EQ("Register a Register b", delegate_.GetAndClearCommands());
|
|
|
| // Unregistering a different accelerator does not affect the other
|
| // accelerator.
|
| @@ -186,16 +193,15 @@ TEST_F(AcceleratorManagerTest, UnregisterAll) {
|
| const Accelerator accelerator_a(VKEY_A, EF_NONE);
|
| delegate_.SetIdForAccelerator(accelerator_a, "a");
|
| TestTarget target1;
|
| - manager_.Register(accelerator_a, AcceleratorManager::kNormalPriority,
|
| - &target1);
|
| const Accelerator accelerator_b(VKEY_B, EF_NONE);
|
| delegate_.SetIdForAccelerator(accelerator_b, "b");
|
| - manager_.Register(accelerator_b, AcceleratorManager::kNormalPriority,
|
| - &target1);
|
| + manager_.Register({accelerator_a, accelerator_b},
|
| + AcceleratorManager::kNormalPriority, &target1);
|
| +
|
| const Accelerator accelerator_c(VKEY_C, EF_NONE);
|
| delegate_.SetIdForAccelerator(accelerator_c, "c");
|
| TestTarget target2;
|
| - manager_.Register(accelerator_c, AcceleratorManager::kNormalPriority,
|
| + manager_.Register({accelerator_c}, AcceleratorManager::kNormalPriority,
|
| &target2);
|
| EXPECT_EQ("Register a Register b Register c",
|
| delegate_.GetAndClearCommands());
|
| @@ -224,7 +230,7 @@ TEST_F(AcceleratorManagerTest, Process) {
|
| for (size_t i = 0; i < (1 << arraysize(kAcceleratorModifiers)); ++i) {
|
| const int modifiers = BuildAcceleratorModifier(i);
|
| Accelerator accelerator(GetAccelerator(VKEY_A, modifiers));
|
| - manager_.Register(accelerator, AcceleratorManager::kNormalPriority,
|
| + manager_.Register({accelerator}, AcceleratorManager::kNormalPriority,
|
| &target);
|
|
|
| // The registered accelerator is processed.
|
| @@ -267,12 +273,12 @@ TEST_F(AcceleratorManagerTest, Reregister) {
|
| const Accelerator accelerator_a(VKEY_A, EF_NONE);
|
| TestTarget target;
|
| delegate_.SetIdForAccelerator(accelerator_a, "a");
|
| - manager_.Register(accelerator_a, AcceleratorManager::kNormalPriority,
|
| + manager_.Register({accelerator_a}, AcceleratorManager::kNormalPriority,
|
| &target);
|
| EXPECT_EQ("Register a", delegate_.GetAndClearCommands());
|
| manager_.UnregisterAll(&target);
|
| EXPECT_EQ("Unregister a", delegate_.GetAndClearCommands());
|
| - manager_.Register(accelerator_a, AcceleratorManager::kNormalPriority,
|
| + manager_.Register({accelerator_a}, AcceleratorManager::kNormalPriority,
|
| &target);
|
| EXPECT_EQ("Register a", delegate_.GetAndClearCommands());
|
| }
|
|
|