Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: ash/mus/accelerators/accelerator_controller_unittest.cc

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: remove unnecessary std::vector. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/mus/accelerators/accelerator_controller_unittest.cc
diff --git a/ash/mus/accelerators/accelerator_controller_unittest.cc b/ash/mus/accelerators/accelerator_controller_unittest.cc
index 0846c34fad55a2d2ab5c4ea9d7706df70222bfb0..8a578808c75981635ccd978033107281a9dc16b2 100644
--- a/ash/mus/accelerators/accelerator_controller_unittest.cc
+++ b/ash/mus/accelerators/accelerator_controller_unittest.cc
@@ -345,8 +345,9 @@ TEST_F(AcceleratorControllerTest, LingeringExitWarningBubble) {
TEST_F(AcceleratorControllerTest, Register) {
const ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_NONE);
+
mfomitchev 2017/01/24 22:56:02 nit: we are adding a lot of empty lines in this fi
thanhph1 2017/01/25 20:12:37 Done.
TestTarget target;
- GetController()->Register(accelerator_a, &target);
+ GetController()->Register({accelerator_a}, &target);
// The registered accelerator is processed.
EXPECT_TRUE(ProcessInController(accelerator_a));
@@ -356,9 +357,10 @@ TEST_F(AcceleratorControllerTest, Register) {
TEST_F(AcceleratorControllerTest, RegisterMultipleTarget) {
const ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_NONE);
TestTarget target1;
- GetController()->Register(accelerator_a, &target1);
+ GetController()->Register({accelerator_a}, &target1);
+
TestTarget target2;
- GetController()->Register(accelerator_a, &target2);
+ GetController()->Register({accelerator_a}, &target2);
// If multiple targets are registered with the same accelerator, the target
// registered later processes the accelerator.
@@ -368,11 +370,12 @@ TEST_F(AcceleratorControllerTest, RegisterMultipleTarget) {
}
TEST_F(AcceleratorControllerTest, Unregister) {
- const ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_NONE);
TestTarget target;
- GetController()->Register(accelerator_a, &target);
+
+ const ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_NONE);
const ui::Accelerator accelerator_b(ui::VKEY_B, ui::EF_NONE);
- GetController()->Register(accelerator_b, &target);
+
+ GetController()->Register({accelerator_a, accelerator_b}, &target);
// Unregistering a different accelerator does not affect the other
// accelerator.
@@ -388,14 +391,18 @@ TEST_F(AcceleratorControllerTest, Unregister) {
}
TEST_F(AcceleratorControllerTest, UnregisterAll) {
- const ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_NONE);
TestTarget target1;
- GetController()->Register(accelerator_a, &target1);
+
+ const ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_NONE);
const ui::Accelerator accelerator_b(ui::VKEY_B, ui::EF_NONE);
- GetController()->Register(accelerator_b, &target1);
+
+ GetController()->Register({accelerator_a, accelerator_b}, &target1);
+
const ui::Accelerator accelerator_c(ui::VKEY_C, ui::EF_NONE);
+
TestTarget target2;
- GetController()->Register(accelerator_c, &target2);
+ GetController()->Register({accelerator_c}, &target2);
+
GetController()->UnregisterAll(&target1);
// All the accelerators registered for |target1| are no longer processed.
@@ -411,7 +418,7 @@ TEST_F(AcceleratorControllerTest, UnregisterAll) {
TEST_F(AcceleratorControllerTest, Process) {
const ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_NONE);
TestTarget target1;
- GetController()->Register(accelerator_a, &target1);
+ GetController()->Register({accelerator_a}, &target1);
// The registered accelerator is processed.
EXPECT_TRUE(ProcessInController(accelerator_a));
@@ -426,7 +433,8 @@ TEST_F(AcceleratorControllerTest, IsRegistered) {
const ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_NONE);
const ui::Accelerator accelerator_shift_a(ui::VKEY_A, ui::EF_SHIFT_DOWN);
TestTarget target;
- GetController()->Register(accelerator_a, &target);
+ GetController()->Register({accelerator_a}, &target);
+
EXPECT_TRUE(GetController()->IsRegistered(accelerator_a));
EXPECT_FALSE(GetController()->IsRegistered(accelerator_shift_a));
GetController()->UnregisterAll(&target);

Powered by Google App Engine
This is Rietveld 408576698