Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: ui/base/accelerators/accelerator_manager_delegate.h

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Add server log when adding accelerator vector. Fix/Refactor codes/comments/format. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/accelerators/accelerator_manager_delegate.h
diff --git a/ui/base/accelerators/accelerator_manager_delegate.h b/ui/base/accelerators/accelerator_manager_delegate.h
index e3c6d9ccf6e53ebee773c721a1374ae0b03e18c0..e70329bb9162ce3c71cc866b26d0cd23456212a1 100644
--- a/ui/base/accelerators/accelerator_manager_delegate.h
+++ b/ui/base/accelerators/accelerator_manager_delegate.h
@@ -22,6 +22,13 @@ class UI_BASE_EXPORT AcceleratorManagerDelegate {
// Called when there no more targets are registered for |accelerator|.
virtual void OnAcceleratorUnregistered(const Accelerator& accelerator) = 0;
+ // Called the first time a target is registered for each accelerator in
mfomitchev 2017/01/03 19:54:35 I think this would be a bit more clear: Called wh
thanhph1 2017/01/06 21:55:56 I modified it a bit. Let me know if it's clear. Th
+ // |accelerators|. This is only called the first time a target is registered
+ // for each unique accelerator. For example, if Register() is called twice
+ // with the same accelerator, this is called only for the first call.
+ virtual void OnAcceleratorsRegistered(
+ const std::vector<ui::Accelerator>& accelerators) = 0;
+
protected:
virtual ~AcceleratorManagerDelegate() {}
};

Powered by Google App Engine
This is Rietveld 408576698