Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: services/ui/ws/window_tree.cc

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Add server log when adding accelerator vector. Fix/Refactor codes/comments/format. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/window_tree.cc
diff --git a/services/ui/ws/window_tree.cc b/services/ui/ws/window_tree.cc
index a9d098e8e875b8bb58e9885717c5aa61d75b0c71..5228a789543ab0058760baa0d024c077bc818e94 100644
--- a/services/ui/ws/window_tree.cc
+++ b/services/ui/ws/window_tree.cc
@@ -1760,8 +1760,10 @@ void WindowTree::AddAccelerators(
bool success = true;
for (auto iter = accelerators.begin(); iter != accelerators.end(); ++iter) {
if (!window_manager_state_->event_dispatcher()->AddAccelerator(
- iter->get()->id, std::move(iter->get()->event_matcher)))
+ iter->get()->id, std::move(iter->get()->event_matcher))) {
+ DVLOG(1) << "Can't add accelerator " << iter->get()->id;
mfomitchev 2017/01/03 19:54:35 This isn't detailed enough - compare this to the o
thanhph1 2017/01/06 21:55:56 Done. I reverted this code and put logs in EventDi
success = false;
+ }
}
callback.Run(success);
}

Powered by Google App Engine
This is Rietveld 408576698