Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: ui/base/accelerators/accelerator_manager_delegate.h

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Remove temporary vector. Add comments. Add AddAcceleratorToVector to use in OnAcceleratorRegistered… Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/accelerators/accelerator_manager_delegate.h
diff --git a/ui/base/accelerators/accelerator_manager_delegate.h b/ui/base/accelerators/accelerator_manager_delegate.h
index e3c6d9ccf6e53ebee773c721a1374ae0b03e18c0..df55ecdacfa60135a60b092a443be91924603805 100644
--- a/ui/base/accelerators/accelerator_manager_delegate.h
+++ b/ui/base/accelerators/accelerator_manager_delegate.h
@@ -22,6 +22,12 @@ class UI_BASE_EXPORT AcceleratorManagerDelegate {
// Called when there no more targets are registered for |accelerator|.
virtual void OnAcceleratorUnregistered(const Accelerator& accelerator) = 0;
+ // Register all accelerators in |accelerators| vector with single IPC.
mfomitchev 2016/12/22 21:18:55 This comment describes the behavior of implementat
thanhph 2016/12/24 18:52:16 Done. I updated it to: // Called the first time
+ virtual void OnAcceleratorsRegistered(
+ const std::vector<ui::Accelerator>& accelerators) = 0;
+ virtual void OnAcceleratorsUnregistered(
+ std::vector<ui::Accelerator>& accelerators) = 0;
+
protected:
virtual ~AcceleratorManagerDelegate() {}
};

Powered by Google App Engine
This is Rietveld 408576698