Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2525)

Unified Diff: ash/mus/accelerators/accelerator_controller_registrar.h

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Remove temporary vector. Add comments. Add AddAcceleratorToVector to use in OnAcceleratorRegistered… Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/mus/accelerators/accelerator_controller_registrar.h
diff --git a/ash/mus/accelerators/accelerator_controller_registrar.h b/ash/mus/accelerators/accelerator_controller_registrar.h
index da2841f6979bc5b64bcfcb49f710e495ba346a34..c3fb1dd1357725296ee0966b9e75aaedf2ce2062 100644
--- a/ash/mus/accelerators/accelerator_controller_registrar.h
+++ b/ash/mus/accelerators/accelerator_controller_registrar.h
@@ -8,6 +8,7 @@
#include <stdint.h>
#include <map>
+#include <vector>
#include "ash/mus/accelerators/accelerator_handler.h"
#include "base/macros.h"
@@ -38,10 +39,20 @@ class AcceleratorControllerRegistrar : public AcceleratorHandler,
ui::mojom::EventResult OnAccelerator(uint32_t id,
const ui::Event& event) override;
+ void AddAcceleratorToVector(
mfomitchev 2016/12/22 21:18:55 private, add comment.
thanhph 2016/12/24 18:52:16 Done.
+ const ui::Accelerator& accelerator,
+ std::vector<ui::mojom::AcceleratorPtr>& accelerator_vector);
+
// ui::AcceleratorManagerDelegate:
void OnAcceleratorRegistered(const ui::Accelerator& accelerator) override;
void OnAcceleratorUnregistered(const ui::Accelerator& accelerator) override;
+ // Register multiple accelerators with single IPC.
mfomitchev 2016/12/22 21:18:55 This is part of implementation of ui::AcceleratorM
thanhph 2016/12/24 18:52:16 Done.
+ void OnAcceleratorsRegistered(
+ const std::vector<ui::Accelerator>& accelerators) override;
+ void OnAcceleratorsUnregistered(
+ std::vector<ui::Accelerator>& accelerators) override;
+
private:
friend class AcceleratorControllerRegistrarTestApi;
@@ -86,6 +97,8 @@ class AcceleratorControllerRegistrar : public AcceleratorHandler,
std::unique_ptr<AcceleratorRouter> router_;
+ std::vector<ui::mojom::AcceleratorPtr> accelerator_ptrs_;
+
// Set of registered local ids.
std::set<uint16_t> ids_;

Powered by Google App Engine
This is Rietveld 408576698