Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/global_shortcut_listener_chromeos.cc

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Change register to use accelerator vector. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ash/mus/accelerators/accelerator_controller_registrar.cc ('K') | « ash/mus/accelerators/accelerator_controller_unittest.cc ('k') | ui/base/accelerators/accelerator_manager.h » ('j') | ui/base/accelerators/accelerator_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/global_shortcut_listener_chromeos.cc
diff --git a/chrome/browser/extensions/global_shortcut_listener_chromeos.cc b/chrome/browser/extensions/global_shortcut_listener_chromeos.cc
index 124df83e5dfc393f2b8d5d170df71590104e3ced..efb2e0c0dfde718b5f66acbf12143f43c3a9c4dd 100644
--- a/chrome/browser/extensions/global_shortcut_listener_chromeos.cc
+++ b/chrome/browser/extensions/global_shortcut_listener_chromeos.cc
@@ -48,7 +48,8 @@ bool GlobalShortcutListenerChromeOS::RegisterAcceleratorImpl(
return false;
// TODO(dtseng): Support search key mapping.
- controller->Register(accelerator, this);
+ const std::vector<ui::Accelerator> accelerators = {accelerator};
mfomitchev 2016/12/22 01:04:50 we don't need to create a local variable.
thanhph 2016/12/22 20:36:01 Done.
+ controller->Register(accelerators, this);
return controller->IsRegistered(accelerator);
}
« ash/mus/accelerators/accelerator_controller_registrar.cc ('K') | « ash/mus/accelerators/accelerator_controller_unittest.cc ('k') | ui/base/accelerators/accelerator_manager.h » ('j') | ui/base/accelerators/accelerator_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698