Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: ui/base/accelerators/accelerator_manager.cc

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Add RegisterAccelerator. Use const auto& for vector iteration. Fix names/comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/base/accelerators/accelerator_manager.h" 5 #include "ui/base/accelerators/accelerator_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "ui/base/accelerators/accelerator_manager_delegate.h" 10 #include "ui/base/accelerators/accelerator_manager_delegate.h"
11 11
12 namespace ui { 12 namespace ui {
13 13
14 AcceleratorManager::AcceleratorManager(AcceleratorManagerDelegate* delegate) 14 AcceleratorManager::AcceleratorManager(AcceleratorManagerDelegate* delegate)
15 : delegate_(delegate) {} 15 : delegate_(delegate) {}
16 16
17 AcceleratorManager::~AcceleratorManager() { 17 AcceleratorManager::~AcceleratorManager() {
18 } 18 }
19 19
20 void AcceleratorManager::Register(const Accelerator& accelerator, 20 void AcceleratorManager::Register(
21 HandlerPriority priority, 21 const std::vector<ui::Accelerator>& accelerators,
22 AcceleratorTarget* target) { 22 HandlerPriority priority,
23 AcceleratorTarget* target) {
23 DCHECK(target); 24 DCHECK(target);
24 AcceleratorTargetList& targets = accelerators_[accelerator].second;
25 DCHECK(std::find(targets.begin(), targets.end(), target) == targets.end())
26 << "Registering the same target multiple times";
27 const bool is_first_target_for_accelerator = targets.empty();
28 25
29 // All priority accelerators go to the front of the line. 26 // Accelerators which haven't already been registered with any target.
30 if (priority == kHighPriority) { 27 std::vector<ui::Accelerator> new_accelerators;
31 DCHECK(!accelerators_[accelerator].first) 28
32 << "Only one high-priority handler can be registered"; 29 for (const ui::Accelerator& accelerator : accelerators) {
33 targets.push_front(target); 30 AcceleratorTargetList& targets = accelerators_[accelerator].second;
34 // Mark that we have a priority accelerator at the front. 31 DCHECK(std::find(targets.begin(), targets.end(), target) == targets.end())
35 accelerators_[accelerator].first = true; 32 << "Registering the same target multiple times";
36 } else { 33 const bool is_first_target_for_accelerator = targets.empty();
37 // We are registering a normal priority handler. If no priority accelerator 34
38 // handler has been registered before us, just add the new handler to the 35 // All priority accelerators go to the front of the line.
39 // front. Otherwise, register it after the first (only) priority handler. 36 if (priority == kHighPriority) {
40 if (!accelerators_[accelerator].first) 37 DCHECK(!accelerators_[accelerator].first)
38 << "Only one high-priority handler can be registered";
41 targets.push_front(target); 39 targets.push_front(target);
42 else 40 // Mark that we have a priority accelerator at the front.
43 targets.insert(++targets.begin(), target); 41 accelerators_[accelerator].first = true;
42 } else {
43 // We are registering a normal priority handler. If no priority
44 // accelerator handler has been registered before us, just add the new
45 // handler to the front. Otherwise, register it after the first (only)
46 // priority handler.
47 if (!accelerators_[accelerator].first)
48 targets.push_front(target);
49 else
50 targets.insert(++targets.begin(), target);
51 }
52 if (is_first_target_for_accelerator)
53 new_accelerators.push_back(accelerator);
44 } 54 }
45 if (is_first_target_for_accelerator && delegate_) 55 if (delegate_ && !new_accelerators.empty())
46 delegate_->OnAcceleratorRegistered(accelerator); 56 delegate_->OnAcceleratorsRegistered(new_accelerators);
57 }
58
59 void AcceleratorManager::RegisterAccelerator(const Accelerator& accelerator,
60 HandlerPriority priority,
61 AcceleratorTarget* target) {
62 Register({accelerator}, priority, target);
47 } 63 }
48 64
49 void AcceleratorManager::Unregister(const Accelerator& accelerator, 65 void AcceleratorManager::Unregister(const Accelerator& accelerator,
50 AcceleratorTarget* target) { 66 AcceleratorTarget* target) {
51 AcceleratorMap::iterator map_iter = accelerators_.find(accelerator); 67 AcceleratorMap::iterator map_iter = accelerators_.find(accelerator);
52 if (map_iter == accelerators_.end()) { 68 if (map_iter == accelerators_.end()) {
53 NOTREACHED() << "Unregistering non-existing accelerator"; 69 NOTREACHED() << "Unregistering non-existing accelerator";
54 return; 70 return;
55 } 71 }
56 72
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 targets->remove(target); 146 targets->remove(target);
131 if (!targets->empty()) 147 if (!targets->empty())
132 return; 148 return;
133 const ui::Accelerator accelerator = map_iter->first; 149 const ui::Accelerator accelerator = map_iter->first;
134 accelerators_.erase(map_iter); 150 accelerators_.erase(map_iter);
135 if (delegate_) 151 if (delegate_)
136 delegate_->OnAcceleratorUnregistered(accelerator); 152 delegate_->OnAcceleratorUnregistered(accelerator);
137 } 153 }
138 154
139 } // namespace ui 155 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698