Make mash register initial batch of accelerators in single shot.

ui/base/accelerators/accelerator_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_ACCELERATORS_ACCELERATOR_MANAGER_H_
 #define UI_BASE_ACCELERATORS_ACCELERATOR_MANAGER_H_
 
 #include <list>
 #include <map>
 #include <utility>
+#include <vector>
 
 #include "base/macros.h"
 #include "ui/base/accelerators/accelerator.h"
 #include "ui/base/ui_base_export.h"
 #include "ui/events/event_constants.h"
 
 namespace ui {
 
 class AcceleratorManagerDelegate;
 
 // AcceleratorManger handles processing of accelerators. A delegate may be
 // supplied which is notified as unique accelerators are added and removed.
 class UI_BASE_EXPORT AcceleratorManager {
  public:
   enum HandlerPriority {
     kNormalPriority,
     kHighPriority,
   };
 
   explicit AcceleratorManager(AcceleratorManagerDelegate* = nullptr);
   ~AcceleratorManager();
 
-  // Register a keyboard accelerator for the specified target. If multiple
+  // Register keyboard accelerators for the specified target. If multiple
   // targets are registered for an accelerator, a target registered later has
   // higher priority.
-  // |accelerator| is the accelerator to register.
+  // |accelerators| contain accelerators to register.
   // |priority| denotes the priority of the handler.
   // NOTE: In almost all cases, you should specify kNormalPriority for this
   // parameter. Setting it to kHighPriority prevents Chrome from sending the
   // shortcut to the webpage if the renderer has focus, which is not desirable
   // except for very isolated cases.
   // |target| is the AcceleratorTarget that handles the event once the
   // accelerator is pressed.
   // Note that we are currently limited to accelerators that are either:
   // - a key combination including Ctrl or Alt
   // - the escape key
   // - the enter key
   // - any F key (F1, F2, F3 ...)
   // - any browser specific keys (as available on special keyboards)
-  void Register(const Accelerator& accelerator,
+  void Register(const std::vector<ui::Accelerator>& accelerators,
                 HandlerPriority priority,

[sky, 2017/01/27 19:11:14]

Each accelerator may want a different priority, so that Register should take a
vector of accelerator and priority pairs.

[mfomitchev, 2017/01/27 23:12:01]

We don't currently have a use case for registering a bunch of accelerators at
once with different priorities. Do you think we need to design for this now? 

[sky, 2017/01/28 00:09:15]

Given we don't have a need for it now, I'm ok with that is here.

One suggestion though. Given most sites only care about registering one
accelerator at a time, how about providing a function with the same name that is
inlined and calls the vector version?

[thanhph1, 2017/01/30 16:37:54]

I can't use the same name Register for inline function without extra
factorization because the call to Register({accelerator}, priority, target)
(also in unit tests) points the inline function instead of expected vector
version and this results to infinitive recursion calls. I use the name
RegisterAccelerator instead. If we keep the inline Register name, I need to
change from {accelerator} to std::vector<ui::Accelerator>(accelerator), which is
quite wordy. 

                 AcceleratorTarget* target);
 
   // Unregister the specified keyboard accelerator for the specified target.
   void Unregister(const Accelerator& accelerator, AcceleratorTarget* target);
 
   // Unregister all keyboard accelerator for the specified target.
   void UnregisterAll(AcceleratorTarget* target);
 
   // Returns whether |accelerator| is already registered.
   bool IsRegistered(const Accelerator& accelerator) const;
@@ skipping 24 matching lines @@
 
   AcceleratorManagerDelegate* delegate_;
   AcceleratorMap accelerators_;
 
   DISALLOW_COPY_AND_ASSIGN(AcceleratorManager);
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_ACCELERATORS_ACCELERATOR_MANAGER_H_