Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: ash/mus/accelerators/accelerator_controller_registrar.h

Issue 2586333003: Make mash register initial batch of accelerators in single shot. (Closed)
Patch Set: Fix nits/names. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_MUS_ACCELERATORS_ACCELERATOR_CONTROLLER_REGISTRAR_H_ 5 #ifndef ASH_MUS_ACCELERATORS_ACCELERATOR_CONTROLLER_REGISTRAR_H_
6 #define ASH_MUS_ACCELERATORS_ACCELERATOR_CONTROLLER_REGISTRAR_H_ 6 #define ASH_MUS_ACCELERATORS_ACCELERATOR_CONTROLLER_REGISTRAR_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
11 #include <sstream>
12 #include <vector>
11 13
12 #include "ash/mus/accelerators/accelerator_handler.h" 14 #include "ash/mus/accelerators/accelerator_handler.h"
13 #include "base/macros.h" 15 #include "base/macros.h"
14 #include "ui/base/accelerators/accelerator.h" 16 #include "ui/base/accelerators/accelerator.h"
15 #include "ui/base/accelerators/accelerator_manager_delegate.h" 17 #include "ui/base/accelerators/accelerator_manager_delegate.h"
16 #include "ui/events/mojo/event_constants.mojom.h" 18 #include "ui/events/mojo/event_constants.mojom.h"
17 19
18 namespace ash { 20 namespace ash {
19 21
20 class AcceleratorRouter; 22 class AcceleratorRouter;
(...skipping 10 matching lines...) Expand all
31 public ui::AcceleratorManagerDelegate { 33 public ui::AcceleratorManagerDelegate {
32 public: 34 public:
33 AcceleratorControllerRegistrar(WindowManager* window_manager, 35 AcceleratorControllerRegistrar(WindowManager* window_manager,
34 uint16_t id_namespace); 36 uint16_t id_namespace);
35 ~AcceleratorControllerRegistrar() override; 37 ~AcceleratorControllerRegistrar() override;
36 38
37 // AcceleratorHandler: 39 // AcceleratorHandler:
38 ui::mojom::EventResult OnAccelerator(uint32_t id, 40 ui::mojom::EventResult OnAccelerator(uint32_t id,
39 const ui::Event& event) override; 41 const ui::Event& event) override;
40 42
43 private:
44 friend class AcceleratorControllerRegistrarTestApi;
45
41 // ui::AcceleratorManagerDelegate: 46 // ui::AcceleratorManagerDelegate:
42 void OnAcceleratorRegistered(const ui::Accelerator& accelerator) override; 47 void OnAcceleratorRegistered(const ui::Accelerator& accelerator) override;
43 void OnAcceleratorUnregistered(const ui::Accelerator& accelerator) override; 48 void OnAcceleratorUnregistered(const ui::Accelerator& accelerator) override;
49 void OnAcceleratorVectorRegistered(
50 const std::vector<ui::Accelerator>& accelerators) override;
44 51
45 private: 52 // Generate id and add the corresponding accelerator to accelerator vector.
46 friend class AcceleratorControllerRegistrarTestApi; 53 // Creates a PRE_TARGET and POST_TARGET mojom accelerators for the provided
54 // |accelerator| and adds them to the provided |accelerator_vector|.
55 void AddAcceleratorToVector(
56 const ui::Accelerator& accelerator,
57 std::vector<ui::mojom::AcceleratorPtr>& accelerator_vector);
47 58
48 // The flow of accelerators in ash is: 59 // The flow of accelerators in ash is:
49 // . wm::AcceleratorFilter() sees events first as it's a pre-target handler. 60 // . wm::AcceleratorFilter() sees events first as it's a pre-target handler.
50 // . AcceleratorFilter forwards to its delegate, which indirectly is 61 // . AcceleratorFilter forwards to its delegate, which indirectly is
51 // implemented by AcceleratorRouter. 62 // implemented by AcceleratorRouter.
52 // . AcceleratorRouter may early out, if not it calls through to 63 // . AcceleratorRouter may early out, if not it calls through to
53 // AcceleratorController. This stop may stop propagation entirely. 64 // AcceleratorController. This stop may stop propagation entirely.
54 // . If focus is on a Widget, then NativeWidgetAura gets the key event, calls 65 // . If focus is on a Widget, then NativeWidgetAura gets the key event, calls
55 // to Widget::OnKeyEvent(), which calls to FocusManager::OnKeyEvent(), which 66 // to Widget::OnKeyEvent(), which calls to FocusManager::OnKeyEvent(), which
56 // calls to AshFocusManagerFactory::Delegate::ProcessAccelerator() finally 67 // calls to AshFocusManagerFactory::Delegate::ProcessAccelerator() finally
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 // Maps from accelerator to the two ids registered for it. 103 // Maps from accelerator to the two ids registered for it.
93 std::map<ui::Accelerator, Ids> accelerator_to_ids_; 104 std::map<ui::Accelerator, Ids> accelerator_to_ids_;
94 105
95 DISALLOW_COPY_AND_ASSIGN(AcceleratorControllerRegistrar); 106 DISALLOW_COPY_AND_ASSIGN(AcceleratorControllerRegistrar);
96 }; 107 };
97 108
98 } // namespace mus 109 } // namespace mus
99 } // namespace ash 110 } // namespace ash
100 111
101 #endif // ASH_MUS_ACCELERATORS_ACCELERATOR_CONTROLLER_REGISTRAR_H_ 112 #endif // ASH_MUS_ACCELERATORS_ACCELERATOR_CONTROLLER_REGISTRAR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698