GestureRecognizerTest tests both Aura and Unified Gesture Detectors.

GestureRecognizerTest tests both Aura and Unified Gesture Detectors.

This is in preparation of landing the unified GR
(see https://codereview.chromium.org/251543003/).

There are some cases where behavior differs in minor ways.

This is sometimes dealt with by increasing the test's margin of error
(for instance, slop handling is slightly different, so we now
exceed the slop more thoroughly).

This is sometimes dealt with by ignoring the test if the test is
run with the unified GR.

BUG=332418
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266440

[tdresser, 2014-04-25 13:08:15]

Sadrul, does this look like a reasonable approach to testing the aura portion of
the unified GR?

Once the unified GR has stuck, I'll get rid of all the previous aura GR code,
and clean this up.

[sadrul, 2014-04-25 13:44:12]

This looks like an excellent way to test both GRs. LGTM

https://codereview.chromium.org/258633005/diff/1/ui/aura/gestures/gesture_rec...
File ui/aura/gestures/gesture_recognizer_unittest.cc (right):

https://codereview.chromium.org/258633005/diff/1/ui/aura/gestures/gesture_rec...
ui/aura/gestures/gesture_recognizer_unittest.cc:717:
switches::kEnableScrollPrediction);
Aside: We don't enable this flag by default, right? We shouldn't be setting this
flag in the tests. We should set this flag only for scroll-prediction related
tests.

https://codereview.chromium.org/258633005/diff/1/ui/aura/gestures/gesture_rec...
ui/aura/gestures/gesture_recognizer_unittest.cc:1376: kTouchId,
base::TimeTicks::Now() - base::TimeTicks());
Can we use ui::EventTimeForNow() instead?

https://codereview.chromium.org/258633005/diff/1/ui/aura/gestures/gesture_rec...
ui/aura/gestures/gesture_recognizer_unittest.cc:1491: 
Remove blank line

https://codereview.chromium.org/258633005/diff/1/ui/aura/gestures/gesture_rec...
ui/aura/gestures/gesture_recognizer_unittest.cc:1716:
EXPECT_TRUE(delegate->scroll_update());
This expectation change is because we changed the move-delta?

https://codereview.chromium.org/258633005/diff/1/ui/aura/test/aura_test_base.cc
File ui/aura/test/aura_test_base.cc (right):

https://codereview.chromium.org/258633005/diff/1/ui/aura/test/aura_test_base....
ui/aura/test/aura_test_base.cc:57:
set_min_touch_down_duration_in_seconds_for_click(0.0005);
Interesting.

[tdresser, 2014-04-25 16:46:34]

https://codereview.chromium.org/258633005/diff/1/ui/aura/gestures/gesture_rec...
File ui/aura/gestures/gesture_recognizer_unittest.cc (right):

https://codereview.chromium.org/258633005/diff/1/ui/aura/gestures/gesture_rec...
ui/aura/gestures/gesture_recognizer_unittest.cc:717:
switches::kEnableScrollPrediction);
On 2014/04/25 13:44:12, sadrul wrote:
> Aside: We don't enable this flag by default, right? We shouldn't be setting
this
> flag in the tests. We should set this flag only for scroll-prediction related
> tests.

Doesn't look like any tests rely on the flag being set...
I've removed it.

https://codereview.chromium.org/258633005/diff/1/ui/aura/gestures/gesture_rec...
ui/aura/gestures/gesture_recognizer_unittest.cc:1376: kTouchId,
base::TimeTicks::Now() - base::TimeTicks());
On 2014/04/25 13:44:12, sadrul wrote:
> Can we use ui::EventTimeForNow() instead?

Wonderful, done.

https://codereview.chromium.org/258633005/diff/1/ui/aura/gestures/gesture_rec...
ui/aura/gestures/gesture_recognizer_unittest.cc:1491: 
On 2014/04/25 13:44:12, sadrul wrote:
> Remove blank line

Done.

https://codereview.chromium.org/258633005/diff/1/ui/aura/gestures/gesture_rec...
ui/aura/gestures/gesture_recognizer_unittest.cc:1716:
EXPECT_TRUE(delegate->scroll_update());
On 2014/04/25 13:44:12, sadrul wrote:
> This expectation change is because we changed the move-delta?

Correct. Trying to get rid of the touch slop exactly (which is required in order
to get the scroll begin without the update) is impossible to do for both GRs.

To get both GR's working, we just overshoot the slop, which triggers both the
begin and the update.

https://codereview.chromium.org/258633005/diff/1/ui/aura/test/aura_test_base.cc
File ui/aura/test/aura_test_base.cc (right):

https://codereview.chromium.org/258633005/diff/1/ui/aura/test/aura_test_base....
ui/aura/test/aura_test_base.cc:57:
set_min_touch_down_duration_in_seconds_for_click(0.0005);
On 2014/04/25 13:44:12, sadrul wrote:
> Interesting.


Previously the show press event would be dispatched before a tap was possible,
which shouldn't be the case.

https://codereview.chromium.org/258633005/diff/40001/ui/aura/gestures/gesture...
File ui/aura/gestures/gesture_recognizer_unittest.cc (right):

https://codereview.chromium.org/258633005/diff/40001/ui/aura/gestures/gesture...
ui/aura/gestures/gesture_recognizer_unittest.cc:2126:
tes.SendScrollEvent(event_processor(), 300, 300, kTouchId1, delegate.get());
This was necessary due to a change in the unified GR (related to
https://code.google.com/p/chromium/issues/detail?id=357237).

[tdresser, 2014-04-25 16:46:38]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:15:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tdresser@chromium.org/258633005/40001

[commit-bot: I haz the power, 2014-04-25 23:30:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:30:33]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[tdresser, 2014-04-27 17:23:11]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2014-04-27 17:23:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tdresser@chromium.org/258633005/40001

[commit-bot: I haz the power, 2014-04-28 06:05:16]

Change committed as 266440

[tapted, 2014-04-28 06:17:56]

A revert of this CL has been created in
https://codereview.chromium.org/254963003/ by tapted@chromium.org.

The reason for reverting is: Breaks compile on

http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%...

../../ui/aura/gestures/gesture_recognizer_unittest.cc: In constructor
'aura::test::{anonymous}::GestureEventConsumeDelegate::GestureEventConsumeDelegate()':
../../ui/aura/gestures/gesture_recognizer_unittest.cc:354:17: error:
'aura::test::{anonymous}::GestureEventConsumeDelegate::wait_until_event_' will
be initialized after [-Werror=reorder]
../../ui/aura/gestures/gesture_recognizer_unittest.cc:352:7: error:   'int
aura::test::{anonymous}::GestureEventConsumeDelegate::flags_' [-Werror=reorder]
../../ui/aura/gestures/gesture_recognizer_unittest.cc:70:3: error:   when
initialized here [-Werror=reorder].