build/android/pylib/symbols/elf_symbolizer.py - Issue 258633003: Graphical version of the run_binary_size_analysis tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/symbols/elf_symbolizer.py

Issue 258633003: Graphical version of the run_binary_size_analysis tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using the python addr2line wrapper. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/symbols/elf_symbolizer.py

diff --git a/build/android/pylib/symbols/elf_symbolizer.py b/build/android/pylib/symbols/elf_symbolizer.py

index ffcd22facd068ee7510e1c1318334aee2f6ba402..90e99e5a2757770b30d8d3a89d0a34b589212780 100644

--- a/build/android/pylib/symbols/elf_symbolizer.py

+++ b/build/android/pylib/symbols/elf_symbolizer.py

@@ -286,7 +286,8 @@ class ELFSymbolizer(object):

if m:

if not m.group(1).startswith('?'):

source_path = m.group(1)

- source_line = int(m.group(2))

+ if not m.group(2).startswith('?'):

+ source_line = int(m.group(2))

else:

logging.warning('Got invalid symbol path from addr2line: %s' % line2)

« no previous file with comments | « no previous file | tools/binary_size/binary_size_utils.py » ('j') | tools/binary_size/binary_size_utils.py » ('J')