Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258623004: Fixed url to manage specific cloud printers. (Closed)

Created:
6 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed url to manage specific cloud printers. Device id is ref string, not relative path. BUG=366575 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M chrome/browser/resources/local_discovery/local_discovery.js View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cloud_devices/common/cloud_devices_urls.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/cloud_devices/common/cloud_devices_urls.cc View 2 chunks +8 lines, -1 line 0 comments Download
M components/cloud_devices/common/cloud_devices_urls_unittest.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-04-24 16:34:42 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 8 months ago (2014-04-24 16:35:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/258623004/1
6 years, 8 months ago (2014-04-24 16:36:22 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 16:36:23 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-24 16:36:23 UTC) #5
Noam Samuel (WRONG ACCOUNT)
lgtm Just to clarify, it doesn't look like this CL changes the actual URLs, only ...
6 years, 8 months ago (2014-04-24 17:13:28 UTC) #6
Noam Samuel
On 2014/04/24 17:13:28, Noam Samuel (WRONG ACCOUNT) wrote: > lgtm > > Just to clarify, ...
6 years, 8 months ago (2014-04-24 17:36:50 UTC) #7
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 8 months ago (2014-04-24 17:36:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/258623004/1
6 years, 8 months ago (2014-04-24 21:12:55 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:58:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 22:58:58 UTC) #11
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-04-24 23:20:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/258623004/1
6 years, 8 months ago (2014-04-24 23:21:22 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:34:22 UTC) #14
Message was sent while issue was closed. 
Change committed as 266043

Powered by Google App Engine
This is Rietveld 408576698