Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4848)

Unified Diff: content/browser/payments/payment_app_manager.h

Issue 2586203003: PaymentApp: Remove scope_url parameter from Get/SetManifest methods. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/payments/payment_app_manager.h
diff --git a/content/browser/payments/payment_app_manager.h b/content/browser/payments/payment_app_manager.h
index bff191837ebecb5838c467c12e9ff4a89c89c55c..7d97963bc27f1a96636db44af6356bcb00ad0ae0 100644
--- a/content/browser/payments/payment_app_manager.h
+++ b/content/browser/payments/payment_app_manager.h
@@ -12,6 +12,7 @@
#include "components/payments/payment_app.mojom.h"
#include "content/common/content_export.h"
#include "mojo/public/cpp/bindings/binding.h"
+#include "url/gurl.h"
namespace content {
@@ -30,11 +31,10 @@ class CONTENT_EXPORT PaymentAppManager
friend class PaymentAppContentUnitTestBase;
// payments::mojom::PaymentAppManager methods:
- void SetManifest(const std::string& scope,
- payments::mojom::PaymentAppManifestPtr manifest,
+ void Init(const std::string& scope) override;
+ void SetManifest(payments::mojom::PaymentAppManifestPtr manifest,
const SetManifestCallback& callback) override;
- void GetManifest(const std::string& scope,
- const GetManifestCallback& callback) override;
+ void GetManifest(const GetManifestCallback& callback) override;
// Called when an error is detected on binding_.
void OnConnectionError();
@@ -42,10 +42,9 @@ class CONTENT_EXPORT PaymentAppManager
// PaymentAppContextImpl owns PaymentAppManager
PaymentAppContextImpl* payment_app_context_;
+ GURL m_scope;
please use gerrit instead 2016/12/20 16:57:54 scope_ instead of m_scope.
zino 2016/12/20 17:18:37 Ah! yeap.. I was confused Blink and Chromium.. :P
mojo::Binding<payments::mojom::PaymentAppManager> binding_;
-
base::WeakPtrFactory<PaymentAppManager> weak_ptr_factory_;
-
DISALLOW_COPY_AND_ASSIGN(PaymentAppManager);
};

Powered by Google App Engine
This is Rietveld 408576698